Page MenuHomePhorge

Fix From/Reply-To headers (T622657)
ClosedPublic

Authored by machniak on Jun 19 2023, 12:12 PM.
Tags
None
Referenced Files
F17078798: D4382.diff
Tue, Dec 3, 4:38 AM
F17062394: D4382.id.diff
Mon, Dec 2, 10:12 AM
Unknown Object (File)
Mon, Nov 25, 7:02 AM
Unknown Object (File)
Fri, Nov 22, 12:40 PM
Unknown Object (File)
Fri, Nov 22, 2:00 AM
Unknown Object (File)
Fri, Nov 22, 1:53 AM
Unknown Object (File)
Tue, Nov 19, 5:46 PM
Unknown Object (File)
Tue, Nov 19, 5:44 PM
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK320203e36a0a: Fix From/Reply-To headers (T622657)
Summary
  • Fixes duplicate/wrong Reply-To and From header
  • Don't use Laravel global settings, they don't play well with our tenants.
  • We anyway can't check for Laravel global headers in our tests
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/replyto-fix
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 43580
Build 17426: arc lint + arc unit

Event Timeline

machniak created this revision.
mollekopf added inline comments.
src/config/mail.php
95–101

Can we explicitly set 'from' and 'reply_to' to null to be a bit more explicit (besides the comment)?

This revision now requires changes to proceed.Jul 17 2023, 10:06 AM
  • Merge branch 'master' into dev/replyto-fix
  • Be more specific in the config file
This revision is now accepted and ready to land.Jul 24 2023, 2:33 PM
This revision was automatically updated to reflect the committed changes.