Page MenuHomePhorge
Differential D4382

Fix From/Reply-To headers (T622657)
ClosedPublic
Actions

Authored by machniak on Jun 19 2023, 12:12 PM.
Tags
None
Referenced Files
F12224718: D4382.diff
Sat, May 18, 3:53 AM
F12223992: D4382.id12572.diff
Sat, May 18, 2:10 AM
Unknown Object (File)
Thu, May 16, 2:30 PM
Unknown Object (File)
Sun, May 12, 4:47 AM
Unknown Object (File)
Mon, May 6, 8:52 AM
Unknown Object (File)
Sun, May 5, 12:20 AM
Unknown Object (File)
Fri, May 3, 7:45 PM
Unknown Object (File)
Apr 18 2024, 9:43 AM
View All 87 Files
Subscribers
mollekopf
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK320203e36a0a: Fix From/Reply-To headers (T622657)
Summary
  • Fixes duplicate/wrong Reply-To and From header
  • Don't use Laravel global settings, they don't play well with our tenants.
  • We anyway can't check for Laravel global headers in our tests
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/replyto-fix
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 43580
Build 17426: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jun 19 2023, 12:12 PM
machniak created this revision.
Harbormaster completed remote builds in B43412: Diff 12572.Jun 19 2023, 12:12 PM
mollekopf subscribed.Jul 17 2023, 10:06 AM
mollekopf added inline comments.
src/config/mail.php
95–101

Can we explicitly set 'from' and 'reply_to' to null to be a bit more explicit (besides the comment)?

mollekopf requested changes to this revision.Jul 17 2023, 10:06 AM
This revision now requires changes to proceed.Jul 17 2023, 10:06 AM
machniak updated this revision to Diff 12674.Jul 19 2023, 8:54 AM
  • Merge branch 'master' into dev/replyto-fix
  • Be more specific in the config file
Harbormaster completed remote builds in B43580: Diff 12674.Jul 19 2023, 8:54 AM
mollekopf accepted this revision.Jul 24 2023, 2:33 PM
This revision is now accepted and ready to land.Jul 24 2023, 2:33 PM
Closed by commit rK320203e36a0a: Fix From/Reply-To headers (T622657) (authored by machniak). · Explain WhyJul 24 2023, 2:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Mail/
10 lines
config/
18 lines
tests/
Feature/
Jobs/
Password/
4 lines
4 lines
Unit/
Mail/
16 lines

Diff 12674

View Options

src/app/Mail/Helper.php

Loading...
View Options

src/config/mail.php

Loading...
View Options

src/tests/Feature/Jobs/Password/RetentionEmailJobTest.php

Loading...
View Options

src/tests/Feature/Jobs/PasswordResetEmailTest.php

Loading...
View Options

src/tests/Unit/Mail/HelperTest.php

Loading...