Page MenuHomePhorge

Display users with no ACTIVE flag as Not Ready, code cleanup
ClosedPublic

Authored by machniak on Mar 27 2023, 1:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 9, 2:07 PM
Unknown Object (File)
Sat, Jan 4, 1:47 PM
Unknown Object (File)
Sat, Jan 4, 1:47 PM
Unknown Object (File)
Sat, Jan 4, 1:47 PM
Unknown Object (File)
Sat, Jan 4, 1:47 PM
Unknown Object (File)
Sat, Jan 4, 1:47 PM
Unknown Object (File)
Sat, Jan 4, 8:08 AM
Unknown Object (File)
Fri, Jan 3, 1:24 AM
Subscribers
Restricted Project

Details

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/status-active-fixes
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 42284
Build 17084: arc lint + arc unit

Event Timeline

machniak created this revision.
mollekopf added inline comments.
src/app/Observers/DomainObserver.php
95

So should we perhaps just do a $domain->status = Domain::STATUS_NEW? Or what do we intend to preserve?

src/app/Observers/DomainObserver.php
95

I suppose the initial idea was to preserve CONFIRMED and VERIFIED state, but now I think every restored domain should get NEW state only. This is not a show stopper for this diff.

  • Make domain NEW (and only NEW) on restore
This revision is now accepted and ready to land.Mar 30 2023, 5:55 PM
This revision was automatically updated to reflect the committed changes.