Page MenuHomePhorge
Differential D4223

Display users with no ACTIVE flag as Not Ready, code cleanup
ClosedPublic
Actions

Authored by machniak on Mar 27 2023, 1:12 PM.
Tags
None
Referenced Files
F12023331: D4223.id12161.diff
Sun, May 5, 10:31 PM
F12014499: D4223.id.diff
Sun, May 5, 5:19 AM
Unknown Object (File)
Thu, May 2, 9:46 AM
Unknown Object (File)
Wed, Apr 24, 12:45 AM
Unknown Object (File)
Sun, Apr 21, 5:11 PM
Unknown Object (File)
Sun, Apr 21, 5:11 PM
Unknown Object (File)
Sun, Apr 21, 5:11 PM
Unknown Object (File)
Sun, Apr 21, 5:11 PM
View All 85 Files
Subscribers
mollekopf
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK7fbcde301b3e: Display users with no ACTIVE flag as Not Ready, code cleanup
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/status-active-fixes
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 42191
Build 17024: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Mar 27 2023, 1:12 PM
machniak created this revision.
Harbormaster completed remote builds in B42191: Diff 12086.Mar 27 2023, 1:12 PM
mollekopf subscribed.Mar 27 2023, 3:39 PM
mollekopf added inline comments.
src/app/Observers/DomainObserver.php
97

So should we perhaps just do a $domain->status = Domain::STATUS_NEW? Or what do we intend to preserve?

machniak added inline comments.Mar 30 2023, 10:07 AM
src/app/Observers/DomainObserver.php
97

I suppose the initial idea was to preserve CONFIRMED and VERIFIED state, but now I think every restored domain should get NEW state only. This is not a show stopper for this diff.

machniak updated this revision to Diff 12161.Mar 30 2023, 10:17 AM
  • Make domain NEW (and only NEW) on restore
Harbormaster completed remote builds in B42284: Diff 12161.Mar 30 2023, 10:17 AM
machniak updated this revision to Diff 12164.Mar 30 2023, 10:22 AM
  • Add some assertions
Harbormaster completed remote builds in B42287: Diff 12164.Mar 30 2023, 10:22 AM
mollekopf accepted this revision.Mar 30 2023, 5:55 PM
This revision is now accepted and ready to land.Mar 30 2023, 5:55 PM
Closed by commit rK7fbcde301b3e: Display users with no ACTIVE flag as Not Ready, code cleanup (authored by machniak). · Explain WhyMar 31 2023, 9:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
20 lines
Http/
Controllers/
3 lines
Observers/
17 lines
14 lines
17 lines
tests/
Feature/
9 lines
2 lines

Diff 12086

View Options

src/app/Domain.php

Loading...
View Options

src/app/Http/Controllers/RelationController.php

Loading...
View Options

src/app/Observers/DomainObserver.php

Loading...
View Options

src/app/Observers/GroupObserver.php

Loading...
View Options

src/app/Observers/UserObserver.php

Loading...
View Options

src/tests/Feature/GroupTest.php

Loading...
View Options

src/tests/Feature/UserTest.php

Loading...