Page MenuHomePhorge
Differential D4181

Make signup optional
ClosedPublic
Actions

Authored by mollekopf on Mar 22 2023, 1:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 5:56 AM
Unknown Object (File)
Fri, Apr 26, 9:33 PM
Unknown Object (File)
Sun, Apr 21, 5:10 PM
Unknown Object (File)
Sun, Apr 21, 5:10 PM
Unknown Object (File)
Sun, Apr 21, 5:10 PM
Unknown Object (File)
Sun, Apr 21, 5:10 PM
Unknown Object (File)
Sun, Apr 21, 5:10 PM
Unknown Object (File)
Sun, Apr 21, 10:16 AM
View All 92 Files
Subscribers
machniak

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rKa11bd16a5b5e: Make signup optional
rK08424a981d4e: Make signup optional
rKaab9b8229a06: Make signup optional
rKcff77e8fa09f: Make signup optional

Diff Detail

Repository
rK kolab
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42107
Build 16961: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Mar 22 2023, 1:59 PM
mollekopf created this revision.
Harbormaster completed remote builds in B42065: Diff 11942.Mar 22 2023, 1:59 PM
mollekopf added a reviewer: Restricted Project.Mar 22 2023, 1:59 PM
machniak requested changes to this revision.Mar 24 2023, 7:53 AM
machniak subscribed.

Use that option also in routes/api.php to remove API end-points for signup. Also, maybe it would be better to use WITH_SIGNUP for consistency with other WITH_* options.

This revision now requires changes to proceed.Mar 24 2023, 7:53 AM
mollekopf updated this revision to Diff 11990.Mar 24 2023, 9:42 AM

Addressed comments

Harbormaster completed remote builds in B42107: Diff 11990.Mar 24 2023, 9:42 AM
mollekopf updated this revision to Diff 12020.Mar 25 2023, 10:22 AM

Rebased on master

Harbormaster completed remote builds in B42128: Diff 12020.Mar 25 2023, 10:22 AM
machniak accepted this revision.Mar 25 2023, 1:58 PM
This revision is now accepted and ready to land.Mar 25 2023, 1:58 PM
Closed by commit rKa11bd16a5b5e: Make signup optional (authored by mollekopf). · Explain WhyMar 26 2023, 11:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
config.prod/
src/
4 lines
src/
app/
1 line
config/
1 line
resources/
vue/
Widgets/
3 lines
routes/
25 lines

Diff 11990

View Options

config.prod/src/.env

Loading...
View Options

src/app/Utils.php

Loading...
View Options

src/config/app.php

Loading...
View Options

src/resources/vue/Widgets/Menu.vue

Loading...
View Options

src/routes/api.php

Loading...