Do not set the Content-Length on the download response
ClosedPublic
Actions

Authored by mollekopf on Mar 23 2023, 9:00 AM.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rKccff16142c40: Do not set the Content-Length on the download response
rK285bb116b366: Do not set the Content-Length on the download response
rK2f0c3d5f5129: Do not set the Content-Length on the download response

Summary

Seems related to:

Apparently swoole uses the chunked transfer encoding,
and according to the rfc we're not supposed to set Content-Length in
that case.

In any case with the Content-Length header swoole crashes, without
everything seems to work.

Diff Detail

Repository

rK kolab

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42086
Build 16934: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Mar 23 2023, 9:00 AM

mollekopf created this revision.

Harbormaster completed remote builds in B42086: Diff 11963.Mar 23 2023, 9:00 AM

mollekopf added a reviewer: Restricted Project.Mar 23 2023, 9:30 AM

I was thinking that we could do a separate code path for small files that has only one chunk and send Content-Length for them, but it could be done later and I didn't really tested that.

This revision is now accepted and ready to land.Mar 23 2023, 11:51 AM

Closed by commit rKccff16142c40: Do not set the Content-Length on the download response (authored by mollekopf). · Explain WhyMar 26 2023, 11:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

app/

Backends/

Storage.php

1 line

Diff 11963

View Options

src/app/Backends/Storage.php

Do not set the Content-Length on the download responseClosedPublicActions