Per-plan lite period
Don't send end-of-trial notifications if free_months != 1
Details
Details
- Reviewers
mollekopf - Group Reviewers
Restricted Project - Commits
- rK385cdbd81e81: Per-plan trial period
./phpunit
Diff Detail
Diff Detail
- Repository
- rK kolab
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks good to me.
src/app/Observers/EntitlementObserver.php | ||
---|---|---|
130 | Why are we doing this? A comment would be helpful. | |
src/app/Wallet.php | ||
105 | This does not seem problematic to me, we're just bumping updated_at to the first point in time where we have to check it again, no? |
src/app/Observers/EntitlementObserver.php | ||
---|---|---|
130 | Below we calculate the price using updated_at timestamp. | |
src/app/Wallet.php | ||
105 | $apply=false is dry-run. |