Paths

Table of Contentst

Differential D3833

Per-plan trial period
ClosedPublic
Actions

Authored by machniak on Sep 13 2022, 11:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 17, 9:43 AM

	Unknown Object (File)
	Wed, Apr 10, 1:05 AM

	Unknown Object (File)
	Wed, Apr 10, 12:33 AM

	Unknown Object (File)
	Fri, Apr 5, 6:38 AM

	Unknown Object (File)
	Feb 10 2024, 7:08 AM

	Unknown Object (File)
	Feb 9 2024, 4:44 PM

	Unknown Object (File)
	Jan 29 2024, 12:42 PM

	Unknown Object (File)
	Jan 24 2024, 4:04 PM

View All 29 Files

Subscribers

Restricted Project

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rK385cdbd81e81: Per-plan trial period

Summary

Per-plan lite period
Don't send end-of-trial notifications if free_months != 1

Test Plan

./phpunit

Diff Detail

Repository

Branch

dev/plan-free-period

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 40082
Build 16238: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Sep 13 2022, 11:22 AM

machniak created this revision.

Harbormaster completed remote builds in B40082: Diff 10868.Sep 13 2022, 11:22 AM

Looks good to me.

src/app/Observers/EntitlementObserver.php
130	Why are we doing this? A comment would be helpful.
src/app/Wallet.php
105	This does not seem problematic to me, we're just bumping updated_at to the first point in time where we have to check it again, no? Also, $apply is the dry run, so we're not bumping it then?

machniak added inline comments.Sep 13 2022, 2:47 PM

src/app/Observers/EntitlementObserver.php
130	Below we calculate the price using updated_at timestamp.
src/app/Wallet.php
105	$apply=false is dry-run. My idea regarding the comment was to never have updated_at in the future. This way it would be more in sync with life. It's "updated at" not "valid until". It is not really a problem right now, though.

mollekopf accepted this revision.Sep 14 2022, 3:42 PM

This revision is now accepted and ready to land.Sep 14 2022, 3:42 PM

Closed by commit rK385cdbd81e81: Per-plan trial period (authored by machniak). · Explain WhySep 20 2022, 11:47 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

app/

Console/

Commands/

Wallet/

TrialEndCommand.php

6 lines

Entitlement.php

20 lines

Http/

Controllers/

API/

V4/

WalletsController.php

12 lines

Observers/

EntitlementObserver.php

21 lines

6 lines

231 lines

database/

migrations/

2022_09_08_100000_plans_free_months.php

41 lines

seeds/

local/

4 lines

production/

2 lines

tests/

Feature/

Console/

Wallet/

TrialEndTest.php

5 lines

Controller/

WalletsTest.php

14 lines

EntitlementTest.php

22 lines

154 lines

Diff 10868

src/app/Console/Commands/Wallet/TrialEndCommand.php

Loading...

src/app/Entitlement.php

Loading...

src/app/Http/Controllers/API/V4/WalletsController.php

Loading...

src/app/Observers/EntitlementObserver.php

Loading...

src/app/Plan.php

Loading...

src/app/Wallet.php

Loading...

src/database/migrations/2022_09_08_100000_plans_free_months.php

Loading...

src/database/seeds/local/PlanSeeder.php

Loading...

src/database/seeds/production/PlanSeeder.php

Loading...

src/tests/Feature/Console/Wallet/TrialEndTest.php

Loading...

src/tests/Feature/Controller/WalletsTest.php

Loading...

src/tests/Feature/EntitlementTest.php

Loading...

src/tests/Feature/WalletTest.php

Loading...