Page MenuHomePhorge
Differential D3674

Improve performance of finding country code from an IP address
ClosedPublic
Actions

Authored by machniak on Jul 11 2022, 3:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 11:41 AM
Unknown Object (File)
Tue, Apr 30, 11:41 AM
Unknown Object (File)
Tue, Apr 30, 11:41 AM
Unknown Object (File)
Fri, Apr 26, 12:40 PM
Unknown Object (File)
Sun, Apr 21, 4:55 PM
Unknown Object (File)
Tue, Apr 9, 3:55 AM
Unknown Object (File)
Mar 31 2024, 9:42 PM
Unknown Object (File)
Mar 27 2024, 11:00 PM
View All 36 Files
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK4e197faefdef: Improve performance of finding country code from an IP address
rKe140111896b0: Improve performance of finding country code from an IP address
rK59710f910cbd: Improve performance of finding country code from an IP address
rK54ee6862e754: Improve performance of finding country code from an IP address
rK3fd9304077b4: Improve performance of finding country code from an IP address
rK08365b8f316a: Improve performance of finding country code from an IP address
rK07408dda9df1: Improve performance of finding country code from an IP address
rKb6c97ef6ed23: Improve performance of finding country code from an IP address
rKe0caa530aee6: Improve performance of finding country code from an IP address
Summary

Speed up the query from 0.17 sec. to 0.03 sec. Removed redundant indices.

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/ipnets-perf
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 39425
Build 16031: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jul 11 2022, 3:37 PM
machniak created this revision.
Harbormaster completed remote builds in B39425: Diff 10580.Jul 11 2022, 3:37 PM
mollekopf accepted this revision.Jul 14 2022, 1:32 PM
This revision is now accepted and ready to land.Jul 14 2022, 1:32 PM
Closed by commit rK4e197faefdef: Improve performance of finding country code from an IP address (authored by machniak, committed by mollekopf). · Explain WhySep 19 2022, 12:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
Commands/
Data/
Import/
19 lines
16 lines
56 lines
33 lines
Providers/
15 lines
database/
migrations/
97 lines
tests/
Feature/
Controller/
4 lines
4 lines
4 lines
Unit/
77 lines

Diff 10580

View Options

src/app/Console/Commands/Data/Import/IP4NetsCommand.php

Loading...
View Options

src/app/Console/Commands/Data/Import/IP6NetsCommand.php

Loading...
View Options

src/app/IP4Net.php

Loading...
View Options

src/app/IP6Net.php

Loading...
View Options

src/app/Providers/AppServiceProvider.php

Loading...
View Options

src/database/migrations/2022_07_07_100000_ip_nets_optimization.php

Loading...
View Options

src/tests/Feature/Controller/AuthTest.php

Loading...
View Options

src/tests/Feature/Controller/NGINXTest.php

Loading...
View Options

src/tests/Feature/Controller/PasswordResetTest.php

Loading...
View Options

src/tests/Unit/UtilsTest.php

Loading...