./phpunit
Details
- Reviewers
mollekopf - Group Reviewers
Restricted Project - Commits
- rKd4ba42c8fc50: Shared/Group rooms
rK9081df2d7d36: Shared/Group rooms
Diff Detail
- Repository
- rK kolab
- Branch
- dev/group-rooms
- Lint
Lint Skipped - Unit
No Test Coverage - Build Status
Buildable 39308 Build 15989: arc lint + arc unit
Event Timeline
The share table right now does not represent a share in the sense of T583818 atm, and seems more like an ACL.
It links a 'sharable' to a user meaning it will require an entry for every combination. The idea of the "share" intermediary instead was that a "shareable" could be attached to a share and users could be granted a level of access to the "share", so you would need one extra acl entry to grant access to N sharables, instead of N extra entries, at the cost of an extra indirection.
In the room case, as it is currently use I suppose you'd end up with a share per room, so it's a corner case of the concept.
I think we should either separate the "share" and the acl (I would welcome that so we can use it for files as well ;-) ), or rename the share to acl and leave the share for future use.
src/database/migrations/2021_10_27_120000_extend_openvidu_rooms_session_id.php | ||
---|---|---|
35 | Why is this removed? |
I still don't buy your concept of shares. Anyway, acl does not sound that nice regarding naming, I'll use the word permission then.
src/database/migrations/2021_10_27_120000_extend_openvidu_rooms_session_id.php | ||
---|---|---|
35 | It hit me (as I use artisan migrate:refresh sometimes). It does not work if you have long session identifiers in the table. It throws an error. I think it is not that important, so we can have it to stay at 36. Or we need to set session_id to null first. |
- Merge branch 'master' into dev/group-rooms
- Shares -> Permissions, Add group-room SKU
- Add group-room SKU