Page MenuHomePhorge
Differential D3551

Modal dialog component
ClosedPublic
Actions

Authored by machniak on May 6 2022, 3:15 PM.
Tags
None
Referenced Files
F11907657: D3551.diff
Fri, Apr 26, 8:09 PM
Unknown Object (File)
Sun, Apr 21, 4:51 PM
Unknown Object (File)
Fri, Apr 19, 5:18 PM
Unknown Object (File)
Wed, Apr 17, 12:20 PM
Unknown Object (File)
Wed, Apr 17, 8:58 AM
Unknown Object (File)
Sat, Apr 6, 1:44 AM
Unknown Object (File)
Thu, Mar 28, 10:20 PM
Unknown Object (File)
Mar 28 2024, 5:05 PM
View All 43 Files
Subscribers
mollekopf
Restricted Project

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rKafa78bb9d25c: Modal dialog component
Summary

Code de-duplication with a new Vue component for modal dialogs

Test Plan

./phpunit --testsuite=Browser

Diff Detail

Repository
rK kolab
Branch
dev/modal-dialog-widget
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 39074
Build 15857: arc lint + arc unit

Event Timeline

machniak requested review of this revision.May 6 2022, 3:15 PM
machniak created this revision.
Harbormaster completed remote builds in B39065: Diff 10181.May 6 2022, 3:16 PM
machniak updated this revision to Diff 10184.May 6 2022, 3:19 PM
  • Fix regexp
Harbormaster completed remote builds in B39068: Diff 10184.May 6 2022, 3:19 PM
machniak updated this revision to Diff 10190.May 6 2022, 3:36 PM
  • Fix regexp again
Harbormaster completed remote builds in B39074: Diff 10190.May 6 2022, 3:36 PM
mollekopf subscribed.May 18 2022, 3:48 PM

Looks good to me but doesn't currently apply.

src/resources/vue/Wallet.vue
277

This looks like a change in behaviour. Please separate refactorings from changes in behaviour, because this way the change is pretty much invisible to anyone reviewing the git commits or the diff here.

This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 2:46 PM
Closed by commit rKafa78bb9d25c: Modal dialog component (authored by machniak). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
resources/
js/
2 lines
themes/
11 lines
vue/
Admin/
182 lines
Domain/
35 lines
Meet/
134 lines
93 lines
115 lines
Reseller/
68 lines
User/
30 lines
180 lines
Widgets/
38 lines
90 lines
98 lines
tests/
1 line
Browser/
Meet/
18 lines

Diff 10190

View Options

src/resources/js/app.js

Loading...
View Options

src/resources/themes/app.scss

Loading...
View Options

src/resources/vue/Admin/User.vue

Loading...
View Options

src/resources/vue/Domain/Info.vue

Loading...
View Options

src/resources/vue/Meet/Room.vue

Loading...
View Options

src/resources/vue/Meet/RoomOptions.vue

Loading...
View Options

src/resources/vue/Meet/RoomStats.vue

Loading...
View Options

src/resources/vue/Reseller/Invitations.vue

Loading...
View Options

src/resources/vue/User/Info.vue

Loading...
View Options

src/resources/vue/Wallet.vue

Loading...
View Options

src/resources/vue/Widgets/CompanionappList.vue

Loading...
View Options

src/resources/vue/Widgets/ModalDialog.vue

Loading...
View Options

src/resources/vue/Widgets/SupportForm.vue

Loading...
View Options

src/tests/Browser.php

Loading...
View Options

src/tests/Browser/Meet/RoomOptionsTest.php

Loading...