Page MenuHomekolab.org

Modal dialog component
ClosedPublic

Authored by machniak on May 6 2022, 3:15 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rKafa78bb9d25c: Modal dialog component
Summary

Code de-duplication with a new Vue component for modal dialogs

Test Plan

./phpunit --testsuite=Browser

Diff Detail

Repository
rK kolab
Branch
dev/modal-dialog-widget
Lint
Lint Skipped
Unit
No Unit Test Coverage
Build Status
Buildable 39074
Build 15857: arc lint + arc unit

Event Timeline

machniak requested review of this revision.May 6 2022, 3:15 PM
machniak created this revision.
machniak updated this revision to Diff 10184.May 6 2022, 3:19 PM
  • Fix regexp
machniak updated this revision to Diff 10190.May 6 2022, 3:36 PM
  • Fix regexp again

Looks good to me but doesn't currently apply.

src/resources/vue/Wallet.vue
277

This looks like a change in behaviour. Please separate refactorings from changes in behaviour, because this way the change is pretty much invisible to anyone reviewing the git commits or the diff here.

This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 2:46 PM
This revision was automatically updated to reflect the committed changes.