HomePhorge

Recent Activity

Fri, Jan 10

machniak requested changes to D5082: Authentication health check.
Fri, Jan 10, 2:34 PM
mollekopf accepted D5080: Remove "Functional" tests.
Fri, Jan 10, 1:19 PM
mollekopf added a reviewer for D5082: Authentication health check: Restricted Project.
Fri, Jan 10, 12:09 PM
mollekopf requested review of D5082: Authentication health check.
Fri, Jan 10, 12:08 PM

Thu, Jan 9

machniak closed D5078: Cleanup/de-duplicate password validation code.
Thu, Jan 9, 1:35 PM
machniak committed rKcfe362d051c9: Cleanup/de-duplicate password validation code (authored by machniak).
Cleanup/de-duplicate password validation code
Thu, Jan 9, 1:35 PM
machniak closed D5076: Google Takeout driver for DataMigrator.
Thu, Jan 9, 1:35 PM
machniak committed rK3771b0e2172a: Google Takeout driver for DataMigrator (authored by machniak).
Google Takeout driver for DataMigrator
Thu, Jan 9, 1:35 PM

Wed, Jan 8

mollekopf accepted D5078: Cleanup/de-duplicate password validation code.
Wed, Jan 8, 10:03 PM
machniak committed rK81407f41a8c2: Fix Undefined array key "isPending" (authored by machniak).
Fix Undefined array key "isPending"
Wed, Jan 8, 3:00 PM
machniak requested review of D5080: Remove "Functional" tests.
Wed, Jan 8, 2:38 PM
machniak requested review of D5078: Cleanup/de-duplicate password validation code.
Wed, Jan 8, 1:30 PM

Mon, Jan 6

machniak committed rS47fe3292cca0: Fix PHP warning in getFileReference() (authored by machniak).
Fix PHP warning in getFileReference()
Mon, Jan 6, 2:03 PM
machniak committed rSfbf08af75fd7: Fix regressions, don't call gzinflate() on an uncompressed data (authored by machniak).
Fix regressions, don't call gzinflate() on an uncompressed data
Mon, Jan 6, 1:55 PM
machniak committed rRPK12787ff4c220: Tags: Fix removing tags from messages list on tag delete from a mail preview… (authored by machniak).
Tags: Fix removing tags from messages list on tag delete from a mail preview…
Mon, Jan 6, 1:00 PM
mollekopf closed D5074: Token validation when providing it as a password.
Mon, Jan 6, 12:42 PM
mollekopf committed rK77ced2efb642: Token validation when providing it as a password (authored by mollekopf).
Token validation when providing it as a password
Mon, Jan 6, 12:42 PM
machniak committed rRPKb3e686c00a41: Fix PHP warning (authored by machniak).
Fix PHP warning
Mon, Jan 6, 12:35 PM
machniak accepted D5074: Token validation when providing it as a password.
Mon, Jan 6, 12:35 PM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Moved the token validation to findAndAuthenticate, so we can skip mfa when a token has been validated.

Mon, Jan 6, 12:24 PM
machniak requested changes to D5074: Token validation when providing it as a password.

After another look I think we might be doing something wrong here. A valid token should disable/skip 2FA use. Current User::findAndAuthenticate() will not skip 2FA if the password is a valid token.

Mon, Jan 6, 11:34 AM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Comment style

Mon, Jan 6, 11:11 AM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Now with an actual test

Mon, Jan 6, 11:10 AM
machniak requested changes to D5074: Token validation when providing it as a password.
Mon, Jan 6, 10:27 AM
mollekopf updated the diff for D5074: Token validation when providing it as a password.

Addressed comments

Mon, Jan 6, 9:35 AM