User setting to enable/disable calendar week in views "Week" and "Month" at Roundcube
Closed, ResolvedPublic

Description

Please introduce at Kolab Roundcube plugins a calendar week in calendar views "Week" and "Month" as suggested in the screenshots. First suggestion is "Month" by introducing just a small column before the first existing column:

Second suggestion is "Week" where the calendar week information can simply be put into the currently empty cell (e.g. "KW 35" in German, "CW 35" in English):

(moved from https://github.com/roundcube/roundcubemail/issues/6377, creating a "feature request" failed with: Task priority "20" is not a valid task priority. Use a priority keyword to choose a task priority: unbreak, triage, high, normal, low, wish.)

Details

Ticket Type
Task
rsc created this task.Aug 7 2018, 12:30 AM
vanmeeuwen lowered the priority of this task from 40 to Wishlist.Aug 13 2018, 2:27 PM
vanmeeuwen closed this task as Invalid.
vanmeeuwen added a subscriber: vanmeeuwen.

The week number is already included in the miniature calendar on the left-hand side, for both month and week views.

That should suffice, albeit perhaps it can be made slightly more prominent.

rsc claimed this task.Aug 13 2018, 2:50 PM

Closing this as invalid is not nice. It would be really helpful to have at least the second proposal done, given it adds no new screen space requirements. Aside of that, just having calendar weeks in mini-calendar is not really helpful when really actively working with the calendar a lot. Please consider reopening.

rsc reopened this task as Open.Aug 13 2018, 2:51 PM
In T4241#62348, @rsc wrote:

Closing this as invalid is not nice.

You may have noticed there's only a limited number of options, and certainly "Resolved" nor "Spite" seemed more appropriate.

In T4241#62348, @rsc wrote:

It would be really helpful to have at least the second proposal done, given it adds no new screen space requirements. Aside of that, just having calendar weeks in mini-calendar is not really helpful when really actively working with the calendar a lot. Please consider reopening.

I think it will require additional real estate and would require visibility toggling for the responsive skin. I also see little value in adding information in duplicate.

For what I've seen in terms of web-based calendaring interfaces, there's none that add the week number in that kind of space or location. Where week numbers are shown, they tend to be put to the mini-calendar as already implemented.

I'm not sure I understand how actively working with the calendar is assisted by making the current week number more prominently visible, or inversely inhibited by not having the week number present where you suggest it should go.

rsc added a comment.Aug 13 2018, 11:13 PM

Okay, I spent now some time with the code: My whole suggestion is already implemented, there are both, "weekNumbers" and "weekNumberTitle" variables in "plugins/calendar/lib/js/fullcalendar.js" which are later used by "plugins/calendar/calendar_ui.js".

My usage scenario gets likely more clear if you close the side bar (if you need the screen space for appointments), then you end up with no mini-calendar. If you then need to switch to a specific calendar week...well, opening side bar vs. having it shown by default ;-(

Could above mentioned existing code path/option maybe at least made configurable (as roundcube calendar setting for users), please?

rsc added a comment.Aug 14 2018, 12:12 AM

plugins/calendar/calendar.php:

function load_settings()
{
[…]
    $settings['itip_notify'] = (int)$this->rc->config->get('calendar_itip_send_option', $this->defaults['calendar_itip_send_option']);
    $settings['week_numbers'] = 1;  // FIXME, needs to be similar like the line above
[…]
}

plugins/calendar/calendar_ui.js:

[…]
    var fullcalendar_defaults = {
      weekNumbers: settings.week_numbers,
      weekNumberTitle: rcmail.gettext('weekofyear', 'calendar') + ' ',  // FIXME, get better translation
      […]
    }
[…]

Using "weekofyear" is wrong, given it only translates with de_CH to "KW", but I don't see how I could get "weekHeader" from "plugins/jqueryui/js/i18n/jquery.ui.datepicker-de.js". Pointers? :)

rsc renamed this task from Add calendar week in calendar views "Week" and "Month" at Roundcube to User setting to enable/disable calendar week in views "Week" and "Month" at Roundcube.Aug 14 2018, 12:14 AM
machniak closed this task as Resolved.Wed, Nov 28, 12:45 PM
machniak added a subscriber: machniak.

Fixed in e85ff388293.