Page MenuHomePhorge
Create Task
Maniphest T354

testcase-11940: K-W-080504 Attribute aller Termine einer Terminserie ohne Zeitbelegung ändern
Closed, ResolvedPublic
Actions

Details

Ticket Type
Task

Revisions and Commits

ClosedD12 Only set isDirty if something was changed
Restricted Differential Revision

Related Objects
Search...

Event Timeline

mollekopf claimed this task.May 26 2015, 12:05 PM
mollekopf added a project: Restricted Project.
mollekopf subscribed.
• knauss mentioned this in T348: testcase-11676: K-W-080400 Attribute eines Termins ohne Zeitbelegung ändern.Jun 1 2015, 12:48 PM
• knauss subscribed.
  • create a event series
  • change title
  • see mails sent, but attendee status not touched

-> attende status is changed to needs-action

• knauss moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jun 1 2015, 12:49 PM
• knauss mentioned this in T306: testcase-11880: K-W-010620 Attribute aller Termine einer Terminserie ändern.Jun 1 2015, 2:33 PM
• knauss mentioned this in T300: testcase-11854: K-W-010500 Attribute eines Termins mit Zeitbelegung ändern.Jun 1 2015, 2:35 PM
• knauss mentioned this in T302: testcase-11862: K-W-010600 Attribute eines Einzeltermins einer Terminserie ändern.
• knauss added a subtask: T302: testcase-11862: K-W-010600 Attribute eines Einzeltermins einer Terminserie ändern.Jun 1 2015, 2:38 PM
• knauss mentioned this in T304: testcase-11864: K-W-010610 Attribute aller zukünftigen Termine einer Terminserie ändern.Jun 1 2015, 2:42 PM
• knauss added a project: Restricted Project.Jun 3 2015, 8:18 AM
• knauss set Ticket Type to Task.
• knauss claimed this task.Jun 3 2015, 8:21 AM
• knauss moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• knauss added a comment.Jun 3 2015, 12:09 PM

we have detection, when to reset partstatus in akonadi/calendar/incidencechange.cpp (line 1059ff) only if:

resetPartStatus << IncidenceBase::FieldDtStart
                      << IncidenceBase::FieldDtEnd
                      << IncidenceBase::FieldDtStart
                      << IncidenceBase::FieldLocation
                      << IncidenceBase::FieldDtDue
                      << IncidenceBase::FieldDuration
                      << IncidenceBase::FieldRecurrence;

problem so far, is that for recurrnting events IncidenceBase::FieldDtStart, IncidenceBase::FieldDtEnd, IncidenceBase::FieldLocation and IncidenceBase::FieldRecurrence are marked as dirty everytime.

• knauss added a comment.Jun 3 2015, 4:02 PM

i would fix kcalcore to not add these fileds to dirty, if they were not changed.

mollekopf moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jun 5 2015, 12:20 PM
• knauss mentioned this in D12: Only set isDirty if something was changed.Jun 5 2015, 12:33 PM
• knauss mentioned this in T353: testcase-11939: K-W-080503 Datum aller zukünftigen Termine einer Terminserie ohne Zeitbelegung ändern.
• knauss moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• knauss moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• knauss added a revision: Restricted Differential Revision.Jun 5 2015, 12:37 PM
• knauss added a revision: D12: Only set isDirty if something was changed.
• knauss added a comment.EditedJun 5 2015, 12:40 PM

I didn't test every recurrence type (daily, weekly, monthly, yearly) from the iterface. Because I relay on the test case from kcalcore.

mollekopf moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jun 5 2015, 12:42 PM
mollekopf closed this task as Resolved.Jun 22 2015, 9:41 AM
mollekopf closed subtask T302: testcase-11862: K-W-010600 Attribute eines Einzeltermins einer Terminserie ändern as Resolved.Jun 23 2015, 12:26 PM