Recurrences should not randomly marked as dirty, most of the work is done in kcalcore
Details
Details
- Reviewers
mollekopf - Maniphest Tasks
- T354: testcase-11940: K-W-080504 Attribute aller Termine einer Terminserie ohne Zeitbelegung ändern
Diff Detail
Diff Detail
- Repository
- rKP kdepim
- Branch
- dev/invitations
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
As this requires rather extensive changes, and only seems to work for a single recurrence rule: Wouldn't it be easier to clone the incidence, do all the changes, compare to the cloned incidence to see if anything has changed, and reset the dirty flags as required?
This could either be implemented purely in the editor, or as part of the incidence using a Incidence::apply(Incidence) method, that would apply the changes from the given incidence, but would ensure the dirty flags are only changed if actually necessary.
| incidenceeditor-ng/incidencerecurrence.cpp | ||
|---|---|---|
| 286 | Put into the local scope of every if as necessary. | |
| 294–295 | Extract into static function and reuse below. | |
| 297–298 | reuse function from above | |
| 316–322 | reuse function from above | |
| 320–327 | reuse function from above | |
Comment Actions
This could either be implemented purely in the editor, or as part of the incidence using a Incidence::apply(Incidence) method, that would apply the changes from the given incidence, but would ensure the dirty flags are only changed if actually necessary.
Respectively just improve IncidenceBase::assign