Page MenuHomePhorge
Differential D823

Fix AttributeError: Cyrus instance has no attribute 'has_folder' in cleanup_acls()
ClosedPublic
Actions

Authored by machniak on Sep 26 2019, 8:06 AM.
Tags
None
Referenced Files
F11898234: D823.diff
Thu, Apr 25, 4:33 PM
Unknown Object (File)
Wed, Apr 24, 6:15 AM
Unknown Object (File)
Mar 24 2024, 7:02 PM
Unknown Object (File)
Feb 20 2024, 3:17 PM
Unknown Object (File)
Feb 9 2024, 1:14 PM
Unknown Object (File)
Jan 23 2024, 5:08 AM
Unknown Object (File)
Jan 19 2024, 7:26 PM
Unknown Object (File)
Jan 19 2024, 6:00 PM
View All 37 Files
Subscribers
vanmeeuwen

Details

Reviewers
vanmeeuwen
Group Reviewers
PyKolab Developers
Commits
rPd51ded2cb93f: Fix AttributeError: Cyrus instance has no attribute 'has_folder' in…
Summary

Also improve performance by removing has_folder() check, and removed redundant debug code

Diff Detail

Repository
rP pykolab
Branch
dev/cleanup_acls_fix
Lint
Lint Errors
SeverityLocationCodeMessage
Errorpykolab/imap/__init__.py:96E122PEP8 E122
Errorpykolab/imap/__init__.py:104E122PEP8 E122
Errorpykolab/imap/__init__.py:237E122PEP8 E122
Errorpykolab/imap/__init__.py:253E122PEP8 E122
Errorpykolab/imap/__init__.py:278E122PEP8 E122
Errorpykolab/imap/__init__.py:289E122PEP8 E122
Errorpykolab/imap/__init__.py:293E122PEP8 E122
Errorpykolab/imap/__init__.py:297E122PEP8 E122
Errorpykolab/imap/__init__.py:300E122PEP8 E122
Errorpykolab/imap/__init__.py:313E122PEP8 E122
Errorpykolab/imap/__init__.py:324E122PEP8 E122
Errorpykolab/imap/__init__.py:330E122PEP8 E122
Errorpykolab/imap/__init__.py:362E122PEP8 E122
Errorpykolab/imap/__init__.py:432E122PEP8 E122
Errorpykolab/imap/__init__.py:446E122PEP8 E122
Errorpykolab/imap/__init__.py:460E122PEP8 E122
Errorpykolab/imap/__init__.py:472E122PEP8 E122
Errorpykolab/imap/__init__.py:481E122PEP8 E122
Errorpykolab/imap/__init__.py:496E122PEP8 E122
Errorpykolab/imap/__init__.py:510E122PEP8 E122
Errorpykolab/imap/__init__.py:602E122PEP8 E122
Errorpykolab/imap/__init__.py:760E122PEP8 E122
Errorpykolab/imap/__init__.py:804E122PEP8 E122
Errorpykolab/imap/__init__.py:814E122PEP8 E122
Errorpykolab/imap/__init__.py:826E122PEP8 E122
Unit
No Test Coverage
Build Status
Buildable 26230
Build 9733: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Sep 26 2019, 8:07 AM
machniak created this revision.
Harbormaster completed remote builds in B26230: Diff 1915.Sep 26 2019, 8:07 AM
vanmeeuwen requested changes to this revision.Nov 26 2019, 9:21 AM
vanmeeuwen subscribed.
vanmeeuwen added inline comments.
pykolab/imap/__init__.py
71
try:
This revision now requires changes to proceed.Nov 26 2019, 9:21 AM
machniak updated this revision to Diff 2014.Nov 26 2019, 9:32 AM

Fixed "try {" typo

Harbormaster completed remote builds in B27358: Diff 2014.Nov 26 2019, 9:32 AM
machniak marked an inline comment as done.Nov 26 2019, 9:33 AM
vanmeeuwen accepted this revision.Jan 13 2020, 2:10 PM
This revision is now accepted and ready to land.Jan 13 2020, 2:10 PM
Closed by commit rPd51ded2cb93f: Fix AttributeError: Cyrus instance has no attribute 'has_folder' in… (authored by machniak, committed by vanmeeuwen). · Explain WhyJan 13 2020, 2:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
pykolab/
imap/
26 lines

Diff 1915

View Options

pykolab/imap/__init__.py

Loading...