Page MenuHomekolab.org
Differential D823

Fix AttributeError: Cyrus instance has no attribute 'has_folder' in cleanup_acls()
ClosedPublic
Actions

Authored by machniak on Sep 26 2019, 8:06 AM.

Details

Reviewers
vanmeeuwen
Group Reviewers
PyKolab Developers
Commits
rPd51ded2cb93f: Fix AttributeError: Cyrus instance has no attribute 'has_folder' in…
Summary

Also improve performance by removing has_folder() check, and removed redundant debug code

Diff Detail

Repository
rP pykolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Sep 26 2019, 8:07 AM
machniak created this revision.
vanmeeuwen requested changes to this revision.Nov 26 2019, 9:21 AM
vanmeeuwen added a subscriber: vanmeeuwen.
vanmeeuwen added inline comments.
pykolab/imap/__init__.py
67–68
try:
This revision now requires changes to proceed.Nov 26 2019, 9:21 AM
machniak updated this revision to Diff 2014.Nov 26 2019, 9:32 AM

Fixed "try {" typo

machniak marked an inline comment as done.Nov 26 2019, 9:33 AM
vanmeeuwen accepted this revision.Mon, Jan 13, 2:10 PM
This revision is now accepted and ready to land.Mon, Jan 13, 2:10 PM
Closed by commit rPd51ded2cb93f: Fix AttributeError: Cyrus instance has no attribute 'has_folder' in… (authored by machniak, committed by vanmeeuwen). · Explain WhyMon, Jan 13, 2:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mpykolab/imap/__init__.py (26 lines)

Diff 2074

View Options

pykolab/imap/__init__.py

Loading...