Page MenuHomePhorge
Differential D785

Prevent event conflict check jumping into infinite loop
ClosedPublic
Actions

Authored by adomaitis on Aug 1 2019, 9:53 AM.
Tags
None
Referenced Files
F11780061: D785.id.diff
Thu, Apr 18, 8:17 AM
Unknown Object (File)
Wed, Apr 17, 11:29 AM
Unknown Object (File)
Tue, Apr 9, 12:50 PM
Unknown Object (File)
Mon, Apr 8, 5:15 PM
Unknown Object (File)
Sun, Apr 7, 9:07 AM
Unknown Object (File)
Wed, Apr 3, 1:39 PM
Unknown Object (File)
Wed, Apr 3, 1:39 PM
Unknown Object (File)
Wed, Apr 3, 1:39 PM
View All 43 Files
Subscribers
machniak
petersen
vanmeeuwen

Details

Reviewers
vanmeeuwen
Commits
rP88a6fa3f29f9: Prevent event conflict check jumping into infinite loop
Summary

Assuming that if current and next event occurence start time is the same then it is the same occurence.
It is better to ensure that get_next_occurence() returns None in such cases, but there must be a backstop from jumping into infinite loop too.

Test Plan

None

Diff Detail

Repository
rP pykolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adomaitis requested review of this revision.Aug 1 2019, 9:53 AM
adomaitis created this revision.
Harbormaster completed remote builds in B25532: Diff 1769.Aug 1 2019, 9:53 AM
vanmeeuwen updated this revision to Diff 1829.Aug 16 2019, 1:52 PM
  • Clear as many of the lint issues as we can
Harbormaster completed remote builds in B25613: Diff 1829.Aug 20 2019, 10:35 AM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 20 2019, 10:39 AM
Closed by commit rP88a6fa3f29f9: Prevent event conflict check jumping into infinite loop (authored by vanmeeuwen). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
pykolab/
itip/
157 lines

Diff 1835

View Options

pykolab/itip/__init__.py

Loading...