Page MenuHomePhorge

Better detect resource collections who already delegated the event
ClosedPublic

Authored by fjl on Jul 3 2018, 1:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 29, 9:18 AM
Unknown Object (File)
Mon, Nov 25, 8:18 AM
Unknown Object (File)
Fri, Nov 22, 7:18 PM
Unknown Object (File)
Tue, Nov 19, 3:44 PM
Unknown Object (File)
Sun, Nov 3, 1:38 PM
Unknown Object (File)
Sun, Nov 3, 1:17 PM
Unknown Object (File)
Oct 27 2024, 2:52 PM
Unknown Object (File)
Oct 10 2024, 4:48 AM

Details

Reviewers
vanmeeuwen
Group Reviewers
PyKolab Developers
Summary

Even with D461 applied, invitations created by Outlook that contain both participants and resources still fail to update the resource's calendar: The resource reservation ist sent with CUTYPE=RESOURCE;ROLE=NON-PARTICIPANT;RSVP=TRUE. Wallace seems to mis-interprets the ROLE=NON-PARTICIPANT as being part of a delegated resource:

# ignore updates and cancellations to resource collections who already delegated the event
if len(receiving_attendee.get_delegated_to()) > 0 or receiving_attendee.get_role() == kolabformat.NonParticipant:

When delegating a resource, Wallace sets both the role and rsvp state:

# set delegator to NON-PARTICIPANT and RSVP=FALSE
delegator = itip_event['xml'].get_attendee_by_email(original_resource['mail'])
delegator.set_role(kolabformat.NonParticipant)
delegator.set_rsvp(False)

We can take advantage of that and test on both role and rsvp state:

if len(receiving_attendee.get_delegated_to()) > 0 or (receiving_attendee.get_role() == kolabformat.NonParticipant and not receiving_attendee.get_rsvp()):
Test Plan

Use Outlook 2016 to send an invitation to real participants and add a resource reservation. The iTip will contain both as attendee:

ATTENDEE;CN="User (user@domain.de)";RSVP=TRUE:mailto:user@domain.de
ATTENDEE;CN=resource@domain.de;CUTYPE=RESOURCE;ROLE=NON-PARTICIPANT;RSVP=TRUE:mailto:resource@domain.de

Diff Detail

Repository
rP pykolab
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

fjl created this object with edit policy "PyKolab Developers (Project)".

Could anyone please review this patch? it sounds like an important fix to have.

Is there any action I can take to aid in getting this patch (and others) into Kolab?

This revision is now accepted and ready to land.May 17 2019, 10:13 AM

Your patches seem not to apply normally...

Slightly modified version will be included in pykolab-0.8.11.