Paths

Table of Contentst

Respect the greylist setting when the network is not recognized
ClosedPublic
Actions

Authored by mollekopf on Tue, May 19, 3:33 PM.

Project Tags

None

Referenced Files

	F125437540: D5897.1779471599.diff
	Thu, May 21, 5:40 PM

Subscribers

machniak

Details

Reviewers

machniak

Group Reviewers

Restricted Project

Commits

rKdc85f9961f88: Respect the greylist setting when the network is not recognized

Diff Detail

Repository

rK kolab

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 57546
Build 20169: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Tue, May 19, 3:33 PM

mollekopf created this revision.

Harbormaster completed remote builds in B57534: Diff 16864.Tue, May 19, 3:33 PM

I ran into this in testing

machniak requested changes to this revision.Wed, May 20, 7:48 AM

machniak subscribed.

machniak added inline comments.

src/app/Policy/Greylist.php
133	We should move this and the following `if` to after we check the netID.

This revision now requires changes to proceed.Wed, May 20, 7:48 AM

Moved findConnectionsCollection after the netID check again

Harbormaster completed remote builds in B57546: Diff 16867.Wed, May 20, 8:12 AM

mollekopf marked an inline comment as done.Wed, May 20, 8:12 AM

machniak accepted this revision.Wed, May 20, 8:28 AM

This revision is now accepted and ready to land.Wed, May 20, 8:28 AM

Closed by commit rKdc85f9961f88: Respect the greylist setting when the network is not recognized. · Explain WhyWed, May 20, 8:47 AM

This revision was automatically updated to reflect the committed changes.

mollekopf added a commit: rKdc85f9961f88: Respect the greylist setting when the network is not recognized.

Revision Contents
Changeset List

Path

Size

src/

app/

Policy/

Greylist.php

lines

Diff 16867

View Options

src/app/Policy/Greylist.php

Respect the greylist setting when the network is not recognizedClosedPublicActions