Paths

Table of Contentst

Nicely handle warnings on get_dns_record()
ClosedPublic
Actions

Authored by machniak on Mon, May 18, 12:03 PM.

Project Tags

None

Referenced Files

	F125449060: D5894.1779475050.diff
	Thu, May 21, 6:37 PM

	F125437447: D5894.1779471583.diff
	Thu, May 21, 5:39 PM

	F125361355: D5894.1779443033.diff
	Thu, May 21, 9:43 AM

Subscribers

Restricted Project

Details

Reviewers

mollekopf

Group Reviewers

Restricted Project

Commits

rK47bb603339d3: Nicely handle warnings on get_dns_record()

Summary

A warning is converted to an exception by Laravel, we don't want that.

Test Plan

./phpunit

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak requested review of this revision.Mon, May 18, 12:03 PM

machniak created this revision.

Harbormaster completed remote builds in B57523: Diff 16855.Mon, May 18, 12:03 PM

mollekopf accepted this revision.Tue, May 19, 3:13 PM

This revision is now accepted and ready to land.Tue, May 19, 3:13 PM

Closed by commit rK47bb603339d3: Nicely handle warnings on get_dns_record(). · Explain WhyThu, May 21, 10:47 AM

This revision was automatically updated to reflect the committed changes.

machniak added a commit: rK47bb603339d3: Nicely handle warnings on get_dns_record().

Revision Contents
Changeset List

Path

Size

src/

app/

Domain.php

lines

Http/

Resources/

DomainInfoResource.php

lines

Utils.php

lines

tests/

Unit/

UtilsTest.php

lines

Diff 16871

View Options

src/app/Domain.php

View Options

src/app/Http/Resources/DomainInfoResource.php

View Options

src/app/Utils.php

View Options

src/tests/Unit/UtilsTest.php

Nicely handle warnings on get_dns_record()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16871

src/app/Domain.php

src/app/Http/Resources/DomainInfoResource.php

src/app/Utils.php

src/tests/Unit/UtilsTest.php

Nicely handle warnings on get_dns_record()
ClosedPublic
Actions

Revision Contents
Changeset List