Fix Kolab API client
ClosedPublic
Actions

Authored by machniak on Fri, Apr 3, 10:55 AM.

Project Tags

None

Referenced Files

	F117901378: D5874.1775381552.diff
	Sat, Apr 4, 9:32 AM

	F117834911: D5874.1775305285.diff
	Fri, Apr 3, 12:21 PM

Subscribers

Roundcube Kolab Plugins Developers

Details

Reviewers

mollekopf

Group Reviewers

Roundcube Kolab Plugins Developers

Commits

rRPKb17de3d6dc71: Fix Kolab API client

Summary

do not retry login requests, unless it's 429 (rate limit)
do not send any requests until authenticated
support retry on 429 response only
fix minor debug logging issue with ordering
fix cache clearing broken with the recent changes regarding 2FA

Diff Detail

Repository

rRPK roundcubemail-plugins-kolab

Branch

dev/kolab-client-fixes

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 57405
Build 20132: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Fri, Apr 3, 10:55 AM

machniak created this revision.

Harbormaster completed remote builds in B57405: Diff 16814.Fri, Apr 3, 10:55 AM

Fix clearing cache for SSO users

Harbormaster completed remote builds in B57406: Diff 16815.Fri, Apr 3, 11:18 AM

Fix auto-refresh

Harbormaster completed remote builds in B57407: Diff 16816.Fri, Apr 3, 12:14 PM

mollekopf accepted this revision.Fri, Apr 3, 12:15 PM

This revision is now accepted and ready to land.Fri, Apr 3, 12:15 PM

Closed by commit rRPKb17de3d6dc71: Fix Kolab API client. · Explain WhyFri, Apr 3, 12:31 PM

This revision was automatically updated to reflect the committed changes.

machniak added a commit: rRPKb17de3d6dc71: Fix Kolab API client.

Revision Contents
Changeset List

Path

Size

plugins/

kolab/

Kolab/

Client.php

lines

kolab.php

lines

Diff 16814

View Options

plugins/kolab/Kolab/Client.php