- Implement proper authentication
- Fix bunch of errors (e.g. plain file editing)
- skip shared files/folders for now
- Use Smarty v5
Details
- Reviewers
mollekopf - Group Reviewers
Chwala Developers - Commits
- rC64169cbdea28: Kolabfiles: Implement proper authentication, fix bunch of errors
Diff Detail
- Repository
- rC chwala
- Branch
- dev/kolabfiles-sharing
- Lint
Lint Skipped - Unit
No Test Coverage - Build Status
Buildable 56979 Build 20076: arc lint + arc unit
Event Timeline
| lib/drivers/kolabfiles/kolabfiles_file_storage.php | ||
|---|---|---|
| 183 | I'm not sure what this solves atm, we still store username and password in the session and the credentials are used to access the api, this now just creates a separate access token? | |
| lib/drivers/kolabfiles/kolabfiles_file_storage.php | ||
|---|---|---|
| 183 | Well, while working on health checker I found out that the Chwala authentication request was always successful even with an invalid password. So, this is fixing that. Indeed, with SSO we have the token, but in other cases we have the user password. Instead of auth/login we could attempt another API end-point to validate if it works, and only call auth/login if it doesn't, I suppose. | |
| lib/drivers/kolabfiles/kolabfiles_file_storage.php | ||
|---|---|---|
| 183 | So perhaps we can detect then if we already have the token? | |
| lib/drivers/kolabfiles/kolabfiles_file_storage.php | ||
|---|---|---|
| 183 | Actually I was wrong. We're not using access token here, we're using the one-time password. And we can't use it as an API token, so we have to call api/auth/login. I added a comment, and enabled fast mode as a performance improvement. | |