Paths

Table of Contentst

Differential D5805

Stats: Exclude 100% discount accounts from the payers count
ClosedPublic
Actions

Authored by machniak on Jan 22 2026, 2:09 PM.

Project Tags

None

Referenced Files

None

Subscribers

mollekopf

Restricted Project

Details

Reviewers

mollekopf

Group Reviewers

Restricted Project

Commits

rK1ff23d472573: Stats: Exclude 100% discount accounts from the payers count

Test Plan

./phpunit

Diff Detail

Repository

rK kolab

Branch

dev/payers-exclude-100-percent-discount

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 56469
Build 19962: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jan 22 2026, 2:09 PM

machniak created this revision.

Harbormaster completed remote builds in B56469: Diff 16590.Jan 22 2026, 2:09 PM

Seems reasonable otherwise

src/app/Console/Commands/Data/Stats/CollectorCommand.php
72	where('discounts.discount', '!=' 100) should work even with null's I think?

This revision is now accepted and ready to land.Jan 25 2026, 9:49 PM

machniak added inline comments.Jan 26 2026, 10:43 AM

src/app/Console/Commands/Data/Stats/CollectorCommand.php
72	No, it won't.

Closed by commit rK1ff23d472573: Stats: Exclude 100% discount accounts from the payers count. · Explain WhyJan 26 2026, 10:45 AM

This revision was automatically updated to reflect the committed changes.

machniak added a commit: rK1ff23d472573: Stats: Exclude 100% discount accounts from the payers count.

Revision Contents
Changeset List

Path

Size

src/

app/

Console/

Commands/

Data/

Stats/

CollectorCommand.php

lines

Diff 16590

View Options

src/app/Console/Commands/Data/Stats/CollectorCommand.php

Stats: Exclude 100% discount accounts from the payers countClosedPublicActions