...in fork mode stderr is not available (Bad file descriptor error) and thus wallace traceback when it tries to send emails
vanmeeuwen machniak petersen
- Maniphest Tasks
- T3751: Emails stuck in wallace queue until wallace is restarted
T2163: wallace fails to connect to ldap then running in debug 9 mode
T2498: Wallace logs errors when run in debug 9 mode
- rP10f1c173941d: With this patch I'm trying to introduce a file-type object in logger, which…
Make all pykolab log messages appear on level <8. This will isolate pykolab debug messages from 3rd partty libraries debug messages. -d debug -l 8 will print pykolab debug messages only, while -l debug -d 9 will print 3rd party libraries messages in addition to level 8 pykolab messages.
In send_update_notification() we send mail in a loop trying up to 5 times if an error occurrs. But this is the only place where we do this. I think it would make sense to do this in all cases, i.e. in _sendmail(). I see also we don't call smtp.quit() consistently. Once we do this on success only, once we do this on error too.
Eliminating inconsistensies of sending mail from wallace. Now all the logic is in modules._sendmail() wrapper. Invitationpolicy module is using that wrapper and makes it responsible for re-submistion logic.
A few more remarks.
|156 ↗||(On Diff #1382)|
This line would prevent smtp.quit() and other cleanup from being called.
|159 ↗||(On Diff #1382)|
Note that the existing smtplib.SMTP() used to be rebuilt the connection for here.
|163 ↗||(On Diff #1382)|
This does not invoke recreating the smtplib.SMTP() instance, therefore possibly looping?