In some cases kolabd fails to cleanly update IMAP mailbox after LDAP changes. That is usual when result_attribute value is in upper case. Mailbox modification seems to follow slightly different code path, by shortcutting to IMAP pykolab function...
ClosedPublic
Actions

Authored by adomaitis on Mar 12 2018, 1:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 23, 2:04 PM

	Unknown Object (File)
	Sun, Apr 21, 5:14 PM

	Unknown Object (File)
	Sun, Apr 21, 5:14 PM

	Unknown Object (File)
	Sun, Apr 21, 5:14 PM

	Unknown Object (File)
	Sun, Apr 21, 5:14 PM

	Unknown Object (File)
	Sat, Apr 20, 10:09 AM

	Unknown Object (File)
	Wed, Apr 17, 11:21 AM

	Unknown Object (File)
	Tue, Apr 16, 9:19 AM

Subscribers

Details

Reviewers

vanmeeuwen
machniak

Commits

rPae2ba60049a4: In some cases kolabd fails to cleanly update IMAP mailbox after LDAP changes.

Summary

..."has_folder()" instead of going via "user_mailbox_exists()", which has a code to downcase mailbox name.

Do not shortcut to "has_folder()" function, use "user_mailbox_exists()" to downcase mailbox name before checking if it exists.

Test Plan

none

Diff Detail

Repository

rP pykolab

Branch

T80958

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 16879
Build 9340: arc lint + arc unit

Event Timeline

adomaitis created this revision.Mar 12 2018, 1:56 PM

Looks to me like now you'll add user/ prefix twice. See in user_mailbox_extsts() and code above your change.

To avoid double user/ prefix, check if user_mailbox_exists only by result_attribute

machniak accepted this revision.Mar 12 2018, 2:54 PM

This revision is now accepted and ready to land.Mar 12 2018, 2:54 PM

Closed by commit rPae2ba60049a4: In some cases kolabd fails to cleanly update IMAP mailbox after LDAP changes. (authored by adomaitis, committed by adomaitis). · Explain WhyMar 12 2018, 3:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

pykolab/

auth/

ldap/

__init__.py

2 lines

Diff 1285

View Options

In some cases kolabd fails to cleanly update IMAP mailbox after LDAP changes. That is usual when result_attribute value is in upper case. Mailbox modification seems to follow slightly different code path, by shortcutting to IMAP pykolab function...ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1285

pykolab/auth/ldap/__init__.py

In some cases kolabd fails to cleanly update IMAP mailbox after LDAP changes. That is usual when result_attribute value is in upper case. Mailbox modification seems to follow slightly different code path, by shortcutting to IMAP pykolab function...
ClosedPublic
Actions

Revision Contents
Changeset List

pykolab/auth/ldap/init.py