Paths

Table of Contentst

Differential D5643

Optimize setSettings()
ClosedPublic
Actions

Authored by machniak on Sep 25 2025, 8:43 AM.

Project Tags

None

Referenced Files

None

Subscribers

mollekopf

Restricted Project

Details

Reviewers

mollekopf

Group Reviewers

Restricted Project

Commits

rK425d57fab957: Optimize setSettings()

Summary

Specifically calling setSettings() with many keys is faster - uses a single SELECT query

Test Plan

./phpunit

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak requested review of this revision.Sep 25 2025, 8:43 AM

machniak created this revision.

Harbormaster completed remote builds in B55458: Diff 16155.Sep 25 2025, 8:43 AM

We could consider wrapping all updates in a transaction, but I'm not sure it matters anywhere.

This revision is now accepted and ready to land.Sep 26 2025, 11:31 AM

Closed by commit rK425d57fab957: Optimize setSettings(). · Explain WhySep 26 2025, 11:56 AM

This revision was automatically updated to reflect the committed changes.

machniak added a commit: rK425d57fab957: Optimize setSettings().

Revision Contents
Changeset List

Path

Size

src/

app/

Traits/

SettingsTrait.php

lines

Diff 16188

View Options

src/app/Traits/SettingsTrait.php

Optimize setSettings()ClosedPublicActions