I left user:create command intact for now, but it obviously will need some changes
Also, I removed user verify job and command as it wasn't used for some time now.
Details
Details
- Reviewers
mollekopf - Group Reviewers
Restricted Project - Commits
- rK1cf65f23ba1e: Support regular users with roles
./phpunit
Diff Detail
Diff Detail
- Repository
- rK kolab
- Branch
- dev/user-jobs-vs-role
- Lint
Lint Skipped - Unit
No Test Coverage - Build Status
Buildable 54066 Build 19191: arc lint + arc unit
Event Timeline
| src/app/Jobs/User/UpdateJob.php | ||
|---|---|---|
| 32 | It seems like we should abstract these types of checks into a function, not sure what the function would be exactly. Maybe something like $user->hasBackend(), with the role check in the function. Also, I don't really understand why we call delete() when a user is trashed(), but not here. Just a thought, not blocker. | |