Paths

Table of Contentst

Differential D5334

Kolab plugin: configuration overlays
ClosedPublic
Actions

Authored by mollekopf on Jun 6 2025, 2:08 PM.

Project Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rRPK054077542928: Kolab plugin: configuration overlays

Diff Detail

Repository

rRPK roundcubemail-plugins-kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Jun 6 2025, 2:08 PM

mollekopf created this revision.

Harbormaster completed remote builds in B53985: Diff 15342.Jun 6 2025, 2:08 PM

mollekopf added a reviewer: Restricted Project.Jun 6 2025, 2:09 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 6 2025, 2:21 PM

Closed by commit rRPK054077542928: Kolab plugin: configuration overlays. · Explain Why

This revision was automatically updated to reflect the committed changes.

mollekopf added a commit: rRPK054077542928: Kolab plugin: configuration overlays.

mollekopf reopened this revision.Jun 6 2025, 3:25 PM

I suppose handling of 'skin' option could be moved to applyConfiguration()

This revision is now accepted and ready to land.Jun 6 2025, 5:03 PM

In D5334#68964, @machniak wrote:

I suppose handling of 'skin' option could be moved to applyConfiguration()

I didn't because I figured it's "special" in that it's not just written to the config, but I suppose we could handle it in the switch as well.
Let's move it once we have a reason for it.

Revision Contents
Changeset List

Path

Size

plugins/

kolab/

Kolab/

Configuration.php

lines

Diff 15345

plugins/kolab/Kolab/Configuration.php

Loading...