goToSleep already adjusts the sleep time to the available minimum (worst case 0 seconds).

No, it does not. $lifeTime never changes as far as I see. Maybe you should use $secondsLeft instead.

You are right, I confused the two. We are only taking care of the case where lifeTime is set to less than sleep time there.

Maybe we can clarify it somehow, but the logic is (I think):

• If we don't have time to go to sleep another round we exit here (plus a 10s margin, to make sure we finish before the timeout).
• If the entire lifetime is smaller than the sleep timeout (e.g. in tests we use 0), then we use the lifetime in sleep.

So we don't attempt to sleep up until the end, we just don't do the final iteration, and the min() in sleep is essentially a special case mostly for testing.

so I would just leave it as it is, because it maintains the logic the way it used to be.

I think the min is actually useless now, it was only relevant when we used to run the first sleep, and then checked for secondsLeft, but now we will simply break before when we check secondsLeft.