There is no need to only conditionally do it, we have the balance check
for that. This makes the behaviour more predictable in case there is
e.g. a mollie outage, which prevents the topup from functioning (which
will likely also fail on the retry jobs).
Details
Details
- Reviewers
machniak - Group Reviewers
Restricted Project - Commits
- rKbd20c2866cd6: Always try to top-up the wallet on charge
Diff Detail
Diff Detail
- Repository
- rK kolab
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I was thinking about removing the try/catch. If we make a top-up attempt on every WalletCheck job run there's really no need for dispatching a separate job. The only danger will be that if topUpWallet() always throws the rest of the code will never execute, but how big of a danger is that I'm not sure.
IN any case the code implementing --topup option in wallet:charge will not be needed anymore, and I would at least remove it from the schedule.
Comment Actions
Do not retry the payment, we will on the next charge cycle, but make sure email notifications are not interrupted by topup failing.