Page MenuHomePhorge
Differential D497

Well, no, don't abort when encountering invalid XML.
AbandonedPublic
Actions

Authored by dfaure on Jul 31 2017, 4:55 PM.
Tags
Referenced Files
Unknown Object (File)
Mon, Oct 14, 4:27 AM
Unknown Object (File)
Thu, Oct 10, 4:57 PM
Unknown Object (File)
Thu, Oct 10, 9:01 AM
Unknown Object (File)
Thu, Oct 10, 8:23 AM
Unknown Object (File)
Thu, Oct 10, 4:16 AM
Unknown Object (File)
Fri, Sep 27, 12:25 PM
Unknown Object (File)
Fri, Sep 27, 12:22 PM
Unknown Object (File)
Fri, Sep 27, 12:21 PM
View All 95 Files
Subscribers
None

Details

Reviewers
mollekopf
• knauss
knauss2
Summary

With kolab shared folders, you always risk getting some crap as input,
and an abort is just too much.

Diff Detail

Repository
rLK libkolab
Branch
libkolab-1.0
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 11471
Build 9233: arc lint + arc unit

Event Timeline

dfaure created this revision.Jul 31 2017, 4:55 PM
dfaure added reviewers: mollekopf, • knauss, knauss2.Jul 31 2017, 4:57 PM
dfaure added a project: KDE PIM Developers.
dfaure abandoned this revision.Aug 1 2017, 12:12 PM

I was wrong, Critical doesn't abort. What happens is a crash on null pointer just after this method returns KCalPtr(). Here's the proper fix: https://git.kolab.org/D503

Revision Contents
Changeset List

PathSize
kolabformat/
2 lines

Diff 1151

View Options

kolabformat/v2helpers.h

Loading...