Fix crashes when the XML parsing fails.
ClosedPublic

Authored by dfaure on Aug 1 2017, 12:12 PM.

Details

Summary

This code was dereferencing a null pointer, leading to a repeatable
crash of the kolab resource when parsing an invalid event.

Diff Detail

Repository
rLK libkolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Aug 1 2017, 12:12 PM
mollekopf accepted this revision.Aug 9 2017, 5:18 PM
This revision is now accepted and ready to land.Aug 9 2017, 5:18 PM
dfaure added a comment.Aug 9 2017, 6:11 PM

Thanks for the review.

However I can't push, do you know why? My SSH key in git.kolab.org looks correct.

BUILDS PASSED Harbormaster builds for the active diff completed successfully.
PUSHING Pushing changes to "origin/libkolab-1.0".
Exception: You do not have permission to push to this repository.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

My git remote for pushing is ssh://git@git.kolab.org/diffusion/LK/libkolab.git/
Did something change?

In D503#5876, @dfaure wrote:

Thanks for the review.

However I can't push, do you know why? My SSH key in git.kolab.org looks correct.

BUILDS PASSED  Harbormaster builds for the active diff completed successfully.
PUSHING  Pushing changes to "origin/libkolab-1.0".

Exception: You do not have permission to push to this repository.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

My git remote for pushing is ssh://git@git.kolab.org/diffusion/LK/libkolab.git/
Did something change?

Because you removed yourself from the "Library Developers" group which is what gives you push access ;-) I have readded you to the group, hope that works now.

This revision was automatically updated to reflect the committed changes.

I really can't see why I would have removed myself from the lib dev group, nor can I remember doing that, but in any case, it works now. Thanks!