Page MenuHomePhorge
Differential D503

Fix crashes when the XML parsing fails.
ClosedPublic
Actions

Authored by dfaure on Aug 1 2017, 12:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 3:46 AM
Unknown Object (File)
Tue, Apr 9, 7:20 AM
Unknown Object (File)
Thu, Mar 28, 12:57 AM
Unknown Object (File)
Fri, Mar 22, 7:44 AM
Unknown Object (File)
Mar 11 2024, 10:48 AM
Unknown Object (File)
Mar 10 2024, 9:50 PM
Unknown Object (File)
Mar 10 2024, 9:50 PM
Unknown Object (File)
Mar 10 2024, 9:43 PM
View All 87 Files
Subscribers
None

Details

Reviewers
mollekopf
• knauss
knauss2
Commits
rLK73a0ca3642cd: Fix crashes when the XML parsing fails.
Summary

This code was dereferencing a null pointer, leading to a repeatable
crash of the kolab resource when parsing an invalid event.

Diff Detail

Repository
rLK libkolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dfaure created this revision.Aug 1 2017, 12:12 PM
mollekopf accepted this revision.Aug 9 2017, 5:18 PM
This revision is now accepted and ready to land.Aug 9 2017, 5:18 PM
dfaure added a comment.Aug 9 2017, 6:11 PM

Thanks for the review.

However I can't push, do you know why? My SSH key in git.kolab.org looks correct.

BUILDS PASSED Harbormaster builds for the active diff completed successfully.
PUSHING Pushing changes to "origin/libkolab-1.0".
Exception: You do not have permission to push to this repository.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

My git remote for pushing is ssh://git@git.kolab.org/diffusion/LK/libkolab.git/
Did something change?

mollekopf added a comment.Aug 15 2017, 8:23 PM
In D503#5876, @dfaure wrote:

Thanks for the review.

However I can't push, do you know why? My SSH key in git.kolab.org looks correct.

BUILDS PASSED Harbormaster builds for the active diff completed successfully.
PUSHING Pushing changes to "origin/libkolab-1.0".
Exception: You do not have permission to push to this repository.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

My git remote for pushing is ssh://git@git.kolab.org/diffusion/LK/libkolab.git/
Did something change?

Because you removed yourself from the "Library Developers" group which is what gives you push access ;-) I have readded you to the group, hope that works now.

Closed by commit rLK73a0ca3642cd: Fix crashes when the XML parsing fails. (authored by dfaure, committed by dfaure). · Explain WhyAug 15 2017, 9:27 PM
This revision was automatically updated to reflect the committed changes.
dfaure added a comment.Aug 15 2017, 9:30 PM

I really can't see why I would have removed myself from the lib dev group, nor can I remember doing that, but in any case, it works now. Thanks!

Revision Contents
Changeset List

PathSize
kolabformat/
24 lines

Diff 1196

View Options

kolabformat/mimeobject.cpp

Loading...