Well, no, don't abort when encountering invalid XML.
AbandonedPublic
Actions

Authored by dfaure on Jul 31 2017, 4:55 PM.

Tags

Referenced Files

	Unknown Object (File)
	Sat, Sep 7, 9:42 AM

	Unknown Object (File)
	Sat, Sep 7, 6:22 AM

	Unknown Object (File)
	Thu, Sep 5, 12:17 PM

	Unknown Object (File)
	Sat, Aug 31, 10:58 PM

	Unknown Object (File)
	Wed, Aug 28, 3:24 AM

	Unknown Object (File)
	Thu, Aug 22, 11:17 AM

	Unknown Object (File)
	Thu, Aug 22, 1:31 AM

	Unknown Object (File)
	Fri, Aug 16, 11:37 AM

View All 87 Files

Subscribers

None

Details

Reviewers

mollekopf
• knauss
knauss2

Summary

With kolab shared folders, you always risk getting some crap as input,
and an abort is just too much.

Diff Detail

Repository

rLK libkolab

Branch

libkolab-1.0

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 11471
Build 9233: arc lint + arc unit

Event Timeline

dfaure created this revision.Jul 31 2017, 4:55 PM

dfaure added reviewers: mollekopf, • knauss, knauss2.Jul 31 2017, 4:57 PM

dfaure added a project: KDE PIM Developers.

I was wrong, Critical doesn't abort. What happens is a crash on null pointer just after this method returns KCalPtr(). Here's the proper fix: https://git.kolab.org/D503

Revision Contents
Changeset List

Path

Size

kolabformat/

v2helpers.h

2 lines

Diff 1151

View Options

Well, no, don't abort when encountering invalid XML.AbandonedPublicActions