Page MenuHomePhorge
Differential D4890

Exempt liveness checks from logging
ClosedPublic
Actions

Authored by mollekopf on Fri, Aug 23, 12:01 PM.
Tags
None
Referenced Files
F15410253: D4890.id14128.diff
Thu, Sep 19, 1:57 PM
F15403899: D4890.id14028.diff
Thu, Sep 19, 7:41 AM
Unknown Object (File)
Wed, Sep 18, 12:11 AM
Unknown Object (File)
Mon, Sep 16, 6:17 PM
Unknown Object (File)
Fri, Sep 13, 5:23 PM
Unknown Object (File)
Fri, Sep 13, 11:17 AM
Unknown Object (File)
Tue, Sep 10, 6:18 PM
Unknown Object (File)
Sat, Sep 7, 9:40 PM
View All 29 Files
Subscribers
machniak

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rKc6410b01d297: Excempt liveness checks from logging
Summary

In containerized environments we want to run liveness checks every couple of seconds, but there isn't really a point to log all these access attempts.
This just avoids logging the liveness checks.

Diff Detail

Repository
rK kolab
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 48795
Build 18321: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Fri, Aug 23, 12:01 PM
mollekopf created this revision.
Harbormaster completed remote builds in B48795: Diff 14028.Fri, Aug 23, 12:01 PM
mollekopf retitled this revision from Attempt to exempt liveness checks from logging to Exempt liveness checks from logging.Fri, Aug 23, 12:03 PM
mollekopf edited the summary of this revision. (Show Details)
mollekopf added a reviewer: Restricted Project.
mollekopf added a comment.Fri, Aug 23, 12:07 PM

This currently only applies when APP_DEBUG=true, but having a log line every couple of seconds when debugging is still annoying enough IMO.

machniak requested changes to this revision.Wed, Aug 28, 1:14 PM
machniak subscribed.
machniak added inline comments.
src/app/Http/Middleware/RequestLogger.php
23

This would be better to be empty() instead !isset()

This revision now requires changes to proceed.Wed, Aug 28, 1:14 PM
This revision was not accepted when it landed; it landed in state Needs Revision.Fri, Sep 6, 2:20 PM
Closed by commit rKc6410b01d297: Excempt liveness checks from logging (authored by mollekopf). · Explain Why
This revision was automatically updated to reflect the committed changes.
mollekopf added a commit: rKc6410b01d297: Excempt liveness checks from logging.

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
V4/
8 lines
Middleware/
12 lines

Diff 14028

View Options

src/app/Http/Controllers/API/V4/HealthController.php

Loading...
View Options

src/app/Http/Middleware/RequestLogger.php

Loading...