Page MenuHomePhorge
Differential D4830

Add --tenant option where needed
ClosedPublic
Actions

Authored by machniak on Tue, Jul 2, 11:14 AM.
Tags
None
Referenced Files
F13706751: D4830.id13822.diff
Mon, Jul 8, 10:11 PM
F13706259: D4830.id13821.diff
Mon, Jul 8, 9:39 PM
F13701291: D4830.id13843.diff
Mon, Jul 8, 6:05 PM
Unknown Object (File)
Sun, Jul 7, 11:35 PM
Unknown Object (File)
Sun, Jul 7, 10:17 PM
Unknown Object (File)
Sun, Jul 7, 8:43 PM
Unknown Object (File)
Sat, Jul 6, 7:04 PM
Unknown Object (File)
Sat, Jul 6, 1:05 AM
Subscribers
mollekopf
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK870e7b0d2ebf: Add --tenant option where needed
Test Plan

./phpunit tests/Feature/Console

Diff Detail

Repository
rK kolab
Branch
dev/cli-vs-tenant-selection
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 47922
Build 18183: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Tue, Jul 2, 11:14 AM
machniak created this revision.
Harbormaster completed remote builds in B47922: Diff 13821.Tue, Jul 2, 11:14 AM
mollekopf requested changes to this revision.Thu, Jul 4, 9:09 AM
mollekopf subscribed.

Looks good apart from the migration change (which might be fine but doesn't relate to the diff).

src/database/migrations/2024_06_13_100000_signup_codes_tenant_id.php
39

Is this on purpose?

This revision now requires changes to proceed.Thu, Jul 4, 9:09 AM
mollekopf added a comment.Thu, Jul 4, 9:09 AM

You can just push it once you looked over the migration change.

This revision was not accepted when it landed; it landed in state Needs Revision.Thu, Jul 4, 11:59 AM
Closed by commit rK870e7b0d2ebf: Add --tenant option where needed (authored by machniak). · Explain Why
This revision was automatically updated to reflect the committed changes.
machniak added a commit: rK870e7b0d2ebf: Add --tenant option where needed.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
19 lines
Commands/
Data/
Import/
15 lines
Discount/
5 lines
Domain/
15 lines
Package/
9 lines
Plan/
11 lines
Sku/
7 lines
Tenant/
1 line
User/
7 lines
1 line
database/
migrations/
1 line
tests/
Feature/
Console/
Sku/
29 lines

Diff 13821

View Options

src/app/Console/Command.php

Loading...
View Options

src/app/Console/Commands/Data/Import/SignupTokensCommand.php

Loading...
View Options

src/app/Console/Commands/Discount/MergeCommand.php

Loading...
View Options

src/app/Console/Commands/Domain/CreateCommand.php

Loading...
View Options

src/app/Console/Commands/Package/SkusCommand.php

Loading...
View Options

src/app/Console/Commands/Plan/PackagesCommand.php

Loading...
View Options

src/app/Console/Commands/Sku/ListUsersCommand.php

Loading...
View Options

src/app/Console/Commands/Tenant/CreateCommand.php

Loading...
View Options

src/app/Console/Commands/User/CreateCommand.php

Loading...
View Options

src/app/Console/Commands/User/GreylistCommand.php

Loading...
View Options

src/database/migrations/2024_06_13_100000_signup_codes_tenant_id.php

Loading...
View Options

src/tests/Feature/Console/Sku/ListUsersTest.php

Loading...