Page MenuHomePhorge

Avoid unindenting special folders.

Authored by mollekopf on May 15 2024, 9:09 AM.
Referenced Files
F12860748: D4698.diff
Sat, Jun 15, 8:50 PM
Unknown Object (File)
Thu, Jun 13, 4:22 AM
Unknown Object (File)
Wed, Jun 12, 10:17 PM
Unknown Object (File)
Wed, Jun 12, 10:48 AM
Unknown Object (File)
Tue, Jun 11, 7:04 AM
Unknown Object (File)
Mon, Jun 10, 8:11 AM
Unknown Object (File)
Mon, Jun 10, 6:08 AM
Unknown Object (File)
Sat, Jun 8, 12:39 PM



In case of an INBOX.Spam folder this will otherwise reparent INBOX
folders under the now toplevel Spam folder, or in other words break the
folder hierarchy.

Diff Detail

R113 roundcubemail
Lint Skipped
No Test Coverage
Build Status
Buildable 47256
Build 17973: arc lint + arc unit

Event Timeline

mollekopf created this revision.

All special folders are supposed to be displayed as top-level folders on top of the list. No matter they are in fact top-level folders or not.

This fix is for Settings > Folders, but the screenshot in the ticket shows an issue in Mail view too. So, this tells me that's not a proper fix.

If I set some sub-folder as a Spam folder on a system without the INBOX. prefix I got it as expected. So, this is somehow namespace prefix related. Anyway, I'd suggest to investigate rcube_imap::sort_folder_list().

This revision was not accepted when it landed; it landed in state Needs Review.May 15 2024, 11:49 AM
This revision was automatically updated to reflect the committed changes.