Avoid unindenting special folders.
ClosedPublic
Actions

Authored by mollekopf on May 15 2024, 9:09 AM.

Details

Reviewers

Commits

R113:8006e76a2ab6: Avoid reparenting special folders.
R113:577b8c20e034: Avoid reparenting special folders.
R113:b029e4bc56c2: Avoid unindenting special folders.

Summary

In case of an INBOX.Spam folder this will otherwise reparent INBOX
folders under the now toplevel Spam folder, or in other words break the
folder hierarchy.

Diff Detail

Repository

R113 roundcubemail

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.May 15 2024, 9:09 AM

mollekopf created this revision.

Harbormaster completed remote builds in B47256: Diff 13518.May 15 2024, 9:09 AM

mollekopf added a reviewer: machniak.May 15 2024, 9:10 AM

All special folders are supposed to be displayed as top-level folders on top of the list. No matter they are in fact top-level folders or not.

This fix is for Settings > Folders, but the screenshot in the ticket shows an issue in Mail view too. So, this tells me that's not a proper fix.

If I set some sub-folder as a Spam folder on a system without the INBOX. prefix I got it as expected. So, this is somehow namespace prefix related. Anyway, I'd suggest to investigate rcube_imap::sort_folder_list().

This revision was not accepted when it landed; it landed in state Needs Review.May 15 2024, 11:49 AM

Closed by commit R113:b029e4bc56c2: Avoid unindenting special folders. (authored by mollekopf). · Explain Why

This revision was automatically updated to reflect the committed changes.

mollekopf added a commit: R113:b029e4bc56c2: Avoid unindenting special folders..

mollekopf added a commit: R113:577b8c20e034: Avoid reparenting special folders..May 15 2024, 12:50 PM

mollekopf added a commit: R113:8006e76a2ab6: Avoid reparenting special folders..May 22 2024, 9:05 AM