Page MenuHomePhorge

Avoid sending the body on flag change
ClosedPublic

Authored by mollekopf on May 8 2024, 1:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 22, 4:08 AM
Unknown Object (File)
Sat, Jun 15, 8:51 PM
Unknown Object (File)
Thu, Jun 13, 7:37 AM
Unknown Object (File)
Tue, Jun 11, 1:37 PM
Unknown Object (File)
Mon, Jun 10, 5:06 AM
Unknown Object (File)
Thu, Jun 6, 10:42 PM
Unknown Object (File)
Mon, Jun 3, 5:26 PM
Unknown Object (File)
Mon, Jun 3, 2:00 AM
Subscribers

Details

Summary

It's not completely minimal, but much closer:

<Change>
    <ServerId>38b950ebd62cd9a66929c89615d0fc04::37</ServerId>
    <ApplicationData>
        <DateReceived xmlns="uri:Email">2024-05-08T10:57:47.000Z</DateReceived>
        <From xmlns="uri:Email">Sync 1 &lt;user@domain.tld&gt;</From>
        <InternetCPID xmlns="uri:Email">65001</InternetCPID>
        <Subject xmlns="uri:Email">test sync</Subject>
        <To xmlns="uri:Email">To 1 &lt;kolab1@domain.tld&gt;,To 2 &lt;kolab2@domain.tld&gt;</To>
        <Read xmlns="uri:Email">0</Read>
        <Flag xmlns="uri:Email"/>
    </ApplicationData>
</Change>

Should be a major perforamnce enhancer if e.g. a lot of tags are used.

Diff Detail

Repository
rS syncroton
Branch
master
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 47268
Build 17976: arc lint + arc unit

Event Timeline

mollekopf created this revision.
lib/kolab_sync_data_email.php
271

This shouldn't be here.

machniak subscribed.
machniak added inline comments.
lib/kolab_sync_data_email.php
266

I think this needs ?? false.

271

This shouldn't be here.

All above, $prefs, comment and console() call.

272

Instead of duplicating this code here, just move the one from line 503 up (to around line 252).

This revision now requires changes to proceed.May 16 2024, 8:19 AM

Cleanup according to comments

This revision is now accepted and ready to land.May 20 2024, 11:20 AM
This revision was automatically updated to reflect the committed changes.