Page MenuHomePhorge

Avoid sending the body on flag change
ClosedPublic

Authored by mollekopf on Wed, May 8, 1:17 PM.
Tags
None
Referenced Files
F12370161: D4695.id13544.diff
Mon, May 27, 4:30 PM
Unknown Object (File)
Sat, May 25, 5:35 PM
Unknown Object (File)
Fri, May 24, 11:25 PM
Unknown Object (File)
Thu, May 23, 6:56 PM
Unknown Object (File)
Wed, May 22, 6:58 PM
Unknown Object (File)
Wed, May 22, 12:39 AM
Unknown Object (File)
Thu, May 16, 5:10 AM
Unknown Object (File)
Thu, May 16, 4:08 AM
Subscribers

Details

Summary

It's not completely minimal, but much closer:

<Change>
    <ServerId>38b950ebd62cd9a66929c89615d0fc04::37</ServerId>
    <ApplicationData>
        <DateReceived xmlns="uri:Email">2024-05-08T10:57:47.000Z</DateReceived>
        <From xmlns="uri:Email">Sync 1 &lt;user@domain.tld&gt;</From>
        <InternetCPID xmlns="uri:Email">65001</InternetCPID>
        <Subject xmlns="uri:Email">test sync</Subject>
        <To xmlns="uri:Email">To 1 &lt;kolab1@domain.tld&gt;,To 2 &lt;kolab2@domain.tld&gt;</To>
        <Read xmlns="uri:Email">0</Read>
        <Flag xmlns="uri:Email"/>
    </ApplicationData>
</Change>

Should be a major perforamnce enhancer if e.g. a lot of tags are used.

Diff Detail

Repository
rS syncroton
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf created this revision.
lib/kolab_sync_data_email.php
271

This shouldn't be here.

machniak subscribed.
machniak added inline comments.
lib/kolab_sync_data_email.php
266

I think this needs ?? false.

271

This shouldn't be here.

All above, $prefs, comment and console() call.

272

Instead of duplicating this code here, just move the one from line 503 up (to around line 252).

This revision now requires changes to proceed.Thu, May 16, 8:19 AM

Cleanup according to comments

This revision is now accepted and ready to land.Mon, May 20, 11:20 AM
This revision was automatically updated to reflect the committed changes.