Page MenuHomePhorge

AllowedHosts middleware to restrict allowed hosts
ClosedPublic

Authored by mollekopf on Wed, Apr 3, 1:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 2:11 AM
Unknown Object (File)
Wed, Apr 10, 6:49 PM
Unknown Object (File)
Tue, Apr 9, 11:19 PM
Unknown Object (File)
Tue, Apr 9, 8:25 PM
Unknown Object (File)
Tue, Apr 9, 7:39 PM
Unknown Object (File)
Tue, Apr 9, 11:53 AM
Unknown Object (File)
Mon, Apr 8, 3:52 AM
Unknown Object (File)
Sun, Apr 7, 8:30 PM
Subscribers

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rKa89b72e22ff2: AllowedHosts middleware to restrict allowed hosts

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Wed, Apr 3, 1:05 PM

There's a domain/hosts confusion. I went with hosts for the middleware because that also used for e.g. the TrustHosts middleware, but with domain in the config because that's what we use for the other configs ¯\_(ツ)_/¯

machniak subscribed.
machniak added inline comments.
src/config/app.php
87–88

I think services_domain is not used anymore and should be removed.

src/routes/api.php
210

It would be cleaner if we did 'allowedHosts:services' or just 'allowedHosts' here and read the config inside the middleware.

This revision now requires changes to proceed.Thu, Apr 4, 10:54 AM
This revision is now accepted and ready to land.Fri, Apr 5, 12:11 PM