Page MenuHomePhorge
Differential D4622

PHPStan Level 5
ClosedPublic
Actions

Authored by machniak on Dec 28 2023, 9:14 AM.

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rKfe2916da4ce0: PHPStan Level 5
Summary

Mostly type related changes, but it actually found one bug

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/phpstan-level5
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 46241
Build 17819: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Dec 28 2023, 9:14 AM
machniak created this revision.
Harbormaster completed remote builds in B46241: Diff 13283.Dec 28 2023, 9:14 AM
mollekopf accepted this revision.Dec 28 2023, 12:17 PM
This revision is now accepted and ready to land.Dec 28 2023, 12:17 PM
Closed by commit rKfe2916da4ce0: PHPStan Level 5. · Explain WhyDec 29 2023, 10:09 AM
This revision was automatically updated to reflect the committed changes.
machniak added a commit: rKfe2916da4ce0: PHPStan Level 5.

Revision Contents
Changeset List

PathSize
src/
app/
Backends/
2 lines
2 lines
30 lines
Console/
Commands/
Data/
Import/
2 lines
2 lines
Domain/
2 lines
Group/
2 lines
SharedFolder/
2 lines
Wallet/
2 lines
2 lines
2 lines
2 lines
Documents/
2 lines
Http/
Controllers/
API/
4 lines
2 lines
V4/
2 lines
5 lines
Providers/
Payment/
6 lines
4 lines
2 lines
2 lines
Traits/
2 lines
8 lines
2 lines
include/
4 lines
2 lines
tests/
Browser/
Components/
2 lines
Meet/
2 lines
2 lines
2 lines
Reseller/
12 lines
Feature/
Controller/
Reseller/
8 lines
2 lines
2 lines
2 lines
2 lines
4 lines
2 lines

Diff 13283

View Options

src/app/Backends/PGP.php

Loading...
View Options

src/app/Backends/Roundcube.php

Loading...
View Options

src/app/CompanionApp.php

Loading...
View Options

src/app/Console/Commands/Data/Import/IP4NetsCommand.php

Loading...
View Options

src/app/Console/Commands/Data/Import/LdifCommand.php

Loading...
View Options

src/app/Console/Commands/Domain/SetStatusCommand.php

Loading...
View Options

src/app/Console/Commands/Group/CreateCommand.php

Loading...
View Options

src/app/Console/Commands/SharedFolder/CreateCommand.php

Loading...
View Options

src/app/Console/Commands/Wallet/GetBalanceCommand.php

Loading...
View Options

src/app/Console/Commands/Wallet/GetDiscountCommand.php

Loading...
View Options

src/app/Console/Commands/Wallet/MandateCommand.php

Loading...
View Options

src/app/Console/ObjectListCommand.php

Loading...
View Options

src/app/Documents/Receipt.php

Loading...
View Options

src/app/Http/Controllers/API/AuthController.php

Loading...
View Options

src/app/Http/Controllers/API/SignupController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/PaymentsController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/RoomsController.php

Loading...
View Options

src/app/Providers/Payment/Coinbase.php

Loading...
View Options

src/app/Providers/Payment/Mollie.php

Loading...
View Options

src/app/Providers/Payment/Stripe.php

Loading...
View Options

src/app/Tenant.php

Loading...
View Options

src/app/Traits/UserConfigTrait.php

Loading...
View Options

src/app/Utils.php

Loading...
View Options

src/app/Wallet.php

Loading...
View Options

src/include/rcube_imap_generic.php

Loading...
View Options

src/phpstan.neon

Loading...
View Options

src/tests/Browser/Components/QuotaInput.php

Loading...
View Options

src/tests/Browser/Meet/RoomSetupTest.php

Loading...
View Options

src/tests/Browser/PaymentMollieTest.php

Loading...
View Options

src/tests/Browser/PaymentStripeTest.php

Loading...
View Options

src/tests/Browser/Reseller/InvitationsTest.php

Loading...
View Options

src/tests/Feature/Controller/Reseller/InvitationsTest.php

Loading...
View Options

src/tests/Feature/Controller/SkusTest.php

Loading...
View Options

src/tests/Feature/GroupTest.php

Loading...
View Options

src/tests/Feature/ResourceTest.php

Loading...
View Options

src/tests/Feature/SharedFolderTest.php

Loading...
View Options

src/tests/Feature/UserTest.php

Loading...
View Options

src/tests/TestCaseTrait.php

Loading...