Page MenuHomePhorge

Make it possible to configure collabora with internal networking
ClosedPublic

Authored by mollekopf on Dec 26 2023, 8:39 AM.
Tags
None
Referenced Files
F12009711: D4619.diff
Sat, May 4, 10:37 PM
Unknown Object (File)
Sun, Apr 28, 7:31 AM
Unknown Object (File)
Sun, Apr 28, 2:01 AM
Unknown Object (File)
Wed, Apr 24, 4:44 AM
Unknown Object (File)
Wed, Apr 17, 3:25 PM
Unknown Object (File)
Wed, Apr 17, 11:10 AM
Unknown Object (File)
Wed, Apr 17, 11:10 AM
Unknown Object (File)
Wed, Apr 17, 11:09 AM
Subscribers

Details

Summary

We need some extra overrides if collabora and chwala are not reachable
via the same domain internally and externally. This allows us to use
cluster-internal networking for all direct connections.

Diff Detail

Repository
rC chwala
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Dec 26 2023, 8:39 AM
machniak subscribed.

If I'm not mistaken fileapi_wopi_office is already internal (chwala to collabora) connection, no need for *_server option. Am I wrong? As for file_api_server_url, it's from kolab_files plugin. I think it would be good to create and document a separate Chwala option.

This revision now requires changes to proceed.Dec 26 2023, 9:01 AM
This revision was not accepted when it landed; it landed in state Needs Revision.Dec 26 2023, 9:19 AM
This revision was automatically updated to reflect the committed changes.

This has not actually landed.

If I'm not mistaken fileapi_wopi_office is already internal (chwala to collabora) connection, no need for *_server option. Am I wrong?

It seems you're right, I think I got confused by a comment in the config file.

As for file_api_server_url, it's from kolab_files plugin. I think it would be good to create and document a separate Chwala option.

The kolab_files option is kolab_files_server_url (I think?), but I followed the same pattern as kolab_files_url/kolab_files_server_url.

Removed the useless WOPI_OFFICE server variant,
adjusted the default config file to include the new option and remove the misleading note.

This revision is now accepted and ready to land.Dec 28 2023, 9:16 AM