Page MenuHomePhorge

Get wopi with kolabfiles to work
ClosedPublic

Authored by mollekopf on Nov 24 2023, 1:12 PM.
Tags
None
Referenced Files
F12010044: D4588.diff
Sat, May 4, 10:54 PM
Unknown Object (File)
Wed, Apr 17, 11:05 AM
Unknown Object (File)
Wed, Apr 17, 11:05 AM
Unknown Object (File)
Wed, Apr 17, 11:05 AM
Unknown Object (File)
Mon, Apr 15, 11:08 AM
Unknown Object (File)
Mon, Apr 15, 4:29 AM
Unknown Object (File)
Sun, Apr 7, 9:31 AM
Unknown Object (File)
Apr 3 2024, 1:31 PM
Subscribers

Details

Summary

The user is null and could probably be initialized somehow,
but do we really want to?
Maybe just use the user from the session instead?

Diff Detail

Repository
rC chwala
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf created this revision.

I guess it would be good to implement authentication in kolabfiles driver, so it sets the user property, i.e. what kolab driver does. For now, this will work, until we implement sharing, I suppose.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 11 2023, 9:44 AM
This revision was automatically updated to reflect the committed changes.

I guess it would be good to implement authentication in kolabfiles driver, so it sets the user property, i.e. what kolab driver does. For now, this will work, until we implement sharing, I suppose.

It seems like quite a lot of complexity to essentially store a username, so I'm wondering if we can't just avoid it (I'm not sure what the benefit is of doing the roundcube authentication). But if we do decide that its useful I can try to port what the kolab driver does.