Page MenuHomePhorge
Differential D4585

kolabfiles backend
ClosedPublic
Actions

Authored by mollekopf on Nov 24 2023, 1:11 PM.
Tags
None
Referenced Files
F12010050: D4585.diff
Sat, May 4, 10:55 PM
Unknown Object (File)
Thu, May 2, 9:46 PM
Unknown Object (File)
Tue, Apr 30, 4:54 PM
Unknown Object (File)
Tue, Apr 30, 11:56 AM
Unknown Object (File)
Mon, Apr 29, 3:35 AM
Unknown Object (File)
Wed, Apr 17, 5:01 PM
Unknown Object (File)
Wed, Apr 17, 11:04 AM
Unknown Object (File)
Wed, Apr 17, 11:04 AM
View All 54 Files
Subscribers
None

Details

Reviewers
machniak
Commits
rCa7637f6424b5: kolabfiles backend

Diff Detail

Repository
rC chwala
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Nov 24 2023, 1:11 PM
mollekopf created this revision.
Harbormaster completed remote builds in B45832: Diff 13156.Nov 24 2023, 1:12 PM
mollekopf added a reviewer: machniak.Nov 27 2023, 1:38 PM
machniak requested changes to this revision.Nov 27 2023, 3:39 PM
machniak added inline comments.
lib/drivers/kolabfiles/kolabfiles_file_storage.php
47

@var kolabfiles_api

52

Kolabfiles. Also in other places.

248

Maybe set to false what is not implemented.

284

Just return an empty array here.

650

I think we have to implement that in Kolab4 controller class. Look for objectToClient.

756

You don't need two PUT requests. Also, 'library' is from SeaFile. In Kolab4 we have collections, and we should treat them as folders for now, I suppose. I.e. libraries should go away.

This revision now requires changes to proceed.Nov 27 2023, 3:39 PM
mollekopf updated this revision to Diff 13210.Dec 9 2023, 11:11 PM

Cleanup, implemented file/folder moves/renames

Harbormaster completed remote builds in B45943: Diff 13210.Dec 9 2023, 11:11 PM
mollekopf marked 6 inline comments as done.Dec 10 2023, 7:56 AM

While this implementation is not certainly not finished, I'd like to get it merged and take it from there.
If you have a few minor adjustments that you'd like before I merge I'm happy to though.

mollekopf updated this revision to Diff 13213.Dec 10 2023, 8:51 AM

Get timestamps to work

Harbormaster completed remote builds in B45946: Diff 13213.Dec 10 2023, 8:51 AM
machniak accepted this revision.Dec 10 2023, 6:39 PM
This revision is now accepted and ready to land.Dec 10 2023, 6:39 PM
Closed by commit rCa7637f6424b5: kolabfiles backend (authored by mollekopf). · Explain WhyDec 11 2023, 9:44 AM
This revision was automatically updated to reflect the committed changes.
mollekopf added a commit: rCa7637f6424b5: kolabfiles backend.

Revision Contents
Changeset List

PathSize
lib/
drivers/
kolabfiles/
1173 lines

Diff 13225

View Options

lib/drivers/kolabfiles/kolabfiles_file_storage.php

Loading...