Fixed the datetime format for MeetingRequests
ClosedPublic
Actions

Authored by mollekopf on Aug 14 2023, 5:15 PM.

Details

Reviewers

machniak

Group Reviewers

Syncroton Developers

Commits

rSca26c18e388e: Revert "Revert "Fixed the datetime format for MeetingRequests""
rSa287dc7d115a: Fixed the datetime format for MeetingRequests

Summary

It's supposed to be like this:

<StartTime>2023-08-15T11:00:00.000Z</StartTime>

Diff Detail

Repository

rS syncroton

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 44060
Build 17588: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Aug 14 2023, 5:15 PM

mollekopf created this revision.

Harbormaster completed remote builds in B44060: Diff 12935.Aug 14 2023, 5:15 PM

Tested with android, where it now displays the correct time. I'm relatively sure we could remove the globalid shenanigans again, but who knows for sure.

globalObjId is a required element, so we should not remove it.

This revision is now accepted and ready to land.Aug 14 2023, 6:33 PM

In D4511#54200, @machniak wrote:

globalObjId is a required element, so we should not remove it.

I don't mean the globalObjId itself, just that we encode the year/month/date/now is probably useless as it seems to be treated as an opaque blob (which would make sense). Maybe these values are just in there as an ad-hoc uuid mechanism that is supposed to guarantee uniqueness.. in any case, I'll leave it for the time being.

Closed by commit rSa287dc7d115a: Fixed the datetime format for MeetingRequests (authored by mollekopf). · Explain WhyAug 14 2023, 9:57 PM

This revision was automatically updated to reflect the committed changes.