Page MenuHomePhorge
Differential D4499

Improve wallet:balances command
ClosedPublic
Actions

Authored by machniak on Aug 8 2023, 2:07 PM.
Tags
None
Referenced Files
F19450488: D4499.1743100345.diff
Wed, Mar 26, 7:32 PM
F19450485: D4499.1743100343.diff
Wed, Mar 26, 7:32 PM
F19450479: D4499.1743100341.diff
Wed, Mar 26, 7:32 PM
F19450470: D4499.1743100339.diff
Wed, Mar 26, 7:32 PM
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rKc7fc123be2a9: Improve wallet:balances command
Summary

Refacor for performance and remove LIMIT 1000, implement --skip-zeros, --negative and --invalid options

Test Plan

./phpunit tests/Feature/Console/Wallet/BalancesTest.php

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak requested review of this revision.Aug 8 2023, 2:07 PM
machniak created this revision.
Harbormaster completed remote builds in B43976: Diff 12899.Aug 8 2023, 2:07 PM
machniak updated this revision to Diff 12905.Aug 8 2023, 2:29 PM
  • Optimize --skip-zeros and --invalid
Harbormaster completed remote builds in B43979: Diff 12905.Aug 8 2023, 2:29 PM
mollekopf accepted this revision.Aug 9 2023, 10:16 AM
This revision is now accepted and ready to land.Aug 9 2023, 10:16 AM
Closed by commit rKc7fc123be2a9: Improve wallet:balances command. · Explain WhyAug 9 2023, 10:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
Commands/
Wallet/
62 lines
tests/
Feature/
Console/
Wallet/
31 lines

Diff 12917

View Options

src/app/Console/Commands/Wallet/BalancesCommand.php

Loading...
View Options

src/tests/Feature/Console/Wallet/BalancesTest.php

Loading...