Get rid of isDummyOutlookUpdate()
ClosedPublic
Actions

Authored by machniak on Aug 1 2023, 8:12 AM.

Tags

None

Referenced Files

	F12228432: D4487.diff
	Sat, May 18, 10:52 AM

	Unknown Object (File)
	Sat, May 4, 11:27 PM

	Unknown Object (File)
	Sun, Apr 28, 8:43 AM

	Unknown Object (File)
	Apr 17 2024, 10:51 AM

	Unknown Object (File)
	Apr 17 2024, 10:51 AM

	Unknown Object (File)
	Apr 17 2024, 10:50 AM

	Unknown Object (File)
	Apr 17 2024, 10:50 AM

	Unknown Object (File)
	Apr 15 2024, 4:15 AM

View All 61 Files

Subscribers

Syncroton Developers

Details

Reviewers

mollekopf

Group Reviewers

Syncroton Developers

Commits

rS29513eb82bfe: Get rid of isDummyOutlookUpdate()
rS4dc64c381ce8: Get rid of isDummyOutlookUpdate()

Summary

We don't need this complicated code, all we need is to check for the dummy timezone, imo.

Diff Detail

Repository

rS syncroton

Branch

dev/dummy-outlook-update-fix

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 43874
Build 17552: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Aug 1 2023, 8:12 AM

machniak created this revision.

Harbormaster completed remote builds in B43862: Diff 12863.Aug 1 2023, 8:12 AM

mollekopf accepted this revision.Aug 1 2023, 10:09 AM

This revision is now accepted and ready to land.Aug 1 2023, 10:09 AM

Requires the removal of two instances of "$this->setKolabDataItem($event, self::KEY_RESPONSE_DTSTAMP, $dtstamp)"

This revision now requires changes to proceed.Aug 1 2023, 12:21 PM

Fixup

Harbormaster completed remote builds in B43874: Diff 12869.Aug 1 2023, 12:35 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2023, 12:48 PM

Closed by commit rS29513eb82bfe: Get rid of isDummyOutlookUpdate() (authored by machniak, committed by mollekopf). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

kolab_sync_data_calendar.php

55 lines

Diff 12869

View Options

lib/kolab_sync_data_calendar.php

Get rid of isDummyOutlookUpdate()ClosedPublicActions