Get rid of isDummyOutlookUpdate()
ClosedPublic
Actions

Authored by machniak on Aug 1 2023, 8:12 AM.

Tags

None

Referenced Files

	F12010332: D4487.diff
	Sat, May 4, 11:27 PM

	Unknown Object (File)
	Sun, Apr 28, 8:43 AM

	Unknown Object (File)
	Wed, Apr 17, 10:51 AM

	Unknown Object (File)
	Wed, Apr 17, 10:51 AM

	Unknown Object (File)
	Wed, Apr 17, 10:50 AM

	Unknown Object (File)
	Wed, Apr 17, 10:50 AM

	Unknown Object (File)
	Mon, Apr 15, 4:15 AM

	Unknown Object (File)
	Tue, Apr 9, 4:03 PM

View All 60 Files

Subscribers

Syncroton Developers

Details

Reviewers

mollekopf

Group Reviewers

Syncroton Developers

Commits

rS29513eb82bfe: Get rid of isDummyOutlookUpdate()
rS4dc64c381ce8: Get rid of isDummyOutlookUpdate()

Summary

We don't need this complicated code, all we need is to check for the dummy timezone, imo.

Diff Detail

Repository

rS syncroton

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak requested review of this revision.Aug 1 2023, 8:12 AM

machniak created this revision.

Harbormaster completed remote builds in B43862: Diff 12863.Aug 1 2023, 8:12 AM

mollekopf accepted this revision.Aug 1 2023, 10:09 AM

This revision is now accepted and ready to land.Aug 1 2023, 10:09 AM

Requires the removal of two instances of "$this->setKolabDataItem($event, self::KEY_RESPONSE_DTSTAMP, $dtstamp)"

This revision now requires changes to proceed.Aug 1 2023, 12:21 PM

Fixup

Harbormaster completed remote builds in B43874: Diff 12869.Aug 1 2023, 12:35 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2023, 12:48 PM

Closed by commit rS29513eb82bfe: Get rid of isDummyOutlookUpdate() (authored by machniak, committed by mollekopf). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

kolab_sync_data_calendar.php

55 lines

Diff 12875

View Options

lib/kolab_sync_data_calendar.php

Get rid of isDummyOutlookUpdate()ClosedPublicActions